You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/26 08:00:10 UTC

[GitHub] [iotdb] Alima777 opened a new pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Alima777 opened a new pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478


   In FileReaderManager, we cached all opened TsFileSequenceReader and maintain an usage count for each reader.
   
   We register a timed thread (cacheFileReaderClearPeriod=100s) to check if a reader is no longer used.
   
   We could check and release the reader when we decrease its usage count in endQuery.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478#issuecomment-979793180


   
   [![Coverage Status](https://coveralls.io/builds/44560240/badge)](https://coveralls.io/builds/44560240)
   
   Coverage increased (+0.05%) to 67.359% when pulling **3dbbf0d2bc9ac21beeb2172730b01ae21ab33823 on closeReader** into **be4339701e29c91f757c4e4821bd396ef0d8695f on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478#issuecomment-979793180


   
   [![Coverage Status](https://coveralls.io/builds/44560763/badge)](https://coveralls.io/builds/44560763)
   
   Coverage increased (+0.02%) to 67.329% when pulling **3dbbf0d2bc9ac21beeb2172730b01ae21ab33823 on closeReader** into **be4339701e29c91f757c4e4821bd396ef0d8695f on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478#issuecomment-979793180


   
   [![Coverage Status](https://coveralls.io/builds/44560406/badge)](https://coveralls.io/builds/44560406)
   
   Coverage increased (+0.02%) to 67.324% when pulling **3dbbf0d2bc9ac21beeb2172730b01ae21ab33823 on closeReader** into **be4339701e29c91f757c4e4821bd396ef0d8695f on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478#issuecomment-979793180


   
   [![Coverage Status](https://coveralls.io/builds/44560246/badge)](https://coveralls.io/builds/44560246)
   
   Coverage increased (+0.008%) to 67.317% when pulling **3dbbf0d2bc9ac21beeb2172730b01ae21ab33823 on closeReader** into **be4339701e29c91f757c4e4821bd396ef0d8695f on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478#issuecomment-979818644


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4478&resolved=false&types=CODE_SMELL)
   
   [![88.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '88.9%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4478&metric=new_coverage&view=list) [88.9% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4478&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4478&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4478&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4478: [IOTDB-2065] TsFileSequenceReader will be cached for 100s even no longer used

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4478:
URL: https://github.com/apache/iotdb/pull/4478#issuecomment-979793180


   
   [![Coverage Status](https://coveralls.io/builds/44559806/badge)](https://coveralls.io/builds/44559806)
   
   Coverage increased (+0.02%) to 67.324% when pulling **8b41cb1ced8790b8e74452ee1bfbf7d4fa35e8d5 on closeReader** into **be4339701e29c91f757c4e4821bd396ef0d8695f on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org