You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:59:54 UTC

[GitHub] [airflow] Jorricks commented on a diff in pull request #26457: Add user comment to task instance and dag run

Jorricks commented on code in PR #26457:
URL: https://github.com/apache/airflow/pull/26457#discussion_r985396315


##########
airflow/www/static/js/dag/StatusBox.tsx:
##########
@@ -36,15 +36,32 @@ import InstanceTooltip from './InstanceTooltip';
 export const boxSize = 10;
 export const boxSizePx = `${boxSize}px`;
 
-interface SimpleStatusProps extends BoxProps {
+interface StatusWithNotesProps extends BoxProps {
   state: TaskState;
+  containsNotes?: boolean;
 }
+export const StatusWithNotes = ({ state, containsNotes, ...rest }: StatusWithNotesProps) => {
+  const theColor = state && stateColors[state] ? stateColors[state] : 'white';

Review Comment:
   Changed `theColor` to `backgroundColor`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org