You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Łukasz Bownik <lu...@gmail.com> on 2022/11/29 18:04:39 UTC
average PR merge time
Hi.
What is the average PR merge/rejection time?
I see some PRs that are over half a year old.
--
Łukasz Bownik
Re: average PR merge time
Posted by Łukasz Bownik <lu...@gmail.com>.
Ok so I rebased https://github.com/apache/netbeans/pull/4112 and it seems
to build fine - though harness has been skipped :/
It only contains tests so should be quick to review if someone has some
time.
On Thu, Dec 1, 2022 at 3:48 PM Brad Walker <bw...@musings.com> wrote:
> Not at all..
>
> But sometimes a PR might need a little bit of "encouragement" to get over
> the finish line.
>
> And I've had PRs that have gotten a little bit "old", if you will.. Usually
> a simple message to the group that I've rebased the code, tested it out
> again against the latest code base, and it is ready to go, will do the
> trick.
>
>
> -brad w.
>
> On Thu, Dec 1, 2022 at 6:01 AM Łukasz Bownik <lu...@gmail.com>
> wrote:
>
> > " The slowest response times are for issues where the submitter has gone
> > silent and the pull response might need a little bit of work."
> >
> > Does it mean non-critical PRs get starved unless the submitter is
> annoying?
> >
> > On Tue, Nov 29, 2022 at 8:41 PM Neil C Smith <ne...@apache.org>
> > wrote:
> >
> > > On Tue, 29 Nov 2022 at 19:16, Eric Bresie <eb...@gmail.com> wrote:
> > > > Others need to be identified and coordinated for inclusion in a give
> > > release with release manager .
> > >
> > > That only applies to PRs targeting delivery or release** branches,
> > > which tend to be managed a little differently. Also, release team,
> > > not single release manager.
> > >
> > > Neil
> >
> >
>
--
Łukasz Bownik
Re: average PR merge time
Posted by Łukasz Bownik <lu...@gmail.com>.
Oh.. So PR can become to old to merge?
Even with all tests passing?
On Thu, Dec 1, 2022 at 3:48 PM Brad Walker <bw...@musings.com> wrote:
> Not at all..
>
> But sometimes a PR might need a little bit of "encouragement" to get over
> the finish line.
>
> And I've had PRs that have gotten a little bit "old", if you will.. Usually
> a simple message to the group that I've rebased the code, tested it out
> again against the latest code base, and it is ready to go, will do the
> trick.
>
>
> -brad w.
>
> On Thu, Dec 1, 2022 at 6:01 AM Łukasz Bownik <lu...@gmail.com>
> wrote:
>
> > " The slowest response times are for issues where the submitter has gone
> > silent and the pull response might need a little bit of work."
> >
> > Does it mean non-critical PRs get starved unless the submitter is
> annoying?
> >
> > On Tue, Nov 29, 2022 at 8:41 PM Neil C Smith <ne...@apache.org>
> > wrote:
> >
> > > On Tue, 29 Nov 2022 at 19:16, Eric Bresie <eb...@gmail.com> wrote:
> > > > Others need to be identified and coordinated for inclusion in a give
> > > release with release manager .
> > >
> > > That only applies to PRs targeting delivery or release** branches,
> > > which tend to be managed a little differently. Also, release team,
> > > not single release manager.
> > >
> > > Neil
> >
> >
>
--
Łukasz Bownik
Re: average PR merge time
Posted by Brad Walker <bw...@musings.com>.
Not at all..
But sometimes a PR might need a little bit of "encouragement" to get over
the finish line.
And I've had PRs that have gotten a little bit "old", if you will.. Usually
a simple message to the group that I've rebased the code, tested it out
again against the latest code base, and it is ready to go, will do the
trick.
-brad w.
On Thu, Dec 1, 2022 at 6:01 AM Łukasz Bownik <lu...@gmail.com>
wrote:
> " The slowest response times are for issues where the submitter has gone
> silent and the pull response might need a little bit of work."
>
> Does it mean non-critical PRs get starved unless the submitter is annoying?
>
> On Tue, Nov 29, 2022 at 8:41 PM Neil C Smith <ne...@apache.org>
> wrote:
>
> > On Tue, 29 Nov 2022 at 19:16, Eric Bresie <eb...@gmail.com> wrote:
> > > Others need to be identified and coordinated for inclusion in a give
> > release with release manager .
> >
> > That only applies to PRs targeting delivery or release** branches,
> > which tend to be managed a little differently. Also, release team,
> > not single release manager.
> >
> > Neil
>
>
Re: average PR merge time
Posted by Łukasz Bownik <lu...@gmail.com>.
" The slowest response times are for issues where the submitter has gone
silent and the pull response might need a little bit of work."
Does it mean non-critical PRs get starved unless the submitter is annoying?
On Tue, Nov 29, 2022 at 8:41 PM Neil C Smith <ne...@apache.org> wrote:
> On Tue, 29 Nov 2022 at 19:16, Eric Bresie <eb...@gmail.com> wrote:
> > Others need to be identified and coordinated for inclusion in a give
> release with release manager .
>
> That only applies to PRs targeting delivery or release** branches,
> which tend to be managed a little differently. Also, release team,
> not single release manager.
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
--
Łukasz Bownik
Re: average PR merge time
Posted by Neil C Smith <ne...@apache.org>.
On Tue, 29 Nov 2022 at 19:16, Eric Bresie <eb...@gmail.com> wrote:
> Others need to be identified and coordinated for inclusion in a give release with release manager .
That only applies to PRs targeting delivery or release** branches,
which tend to be managed a little differently. Also, release team,
not single release manager.
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: average PR merge time
Posted by Eric Bresie <eb...@gmail.com>.
Looking through some of them many appear to be pending some build check failure resolution.
Others need reviewers/review.
Others need to be identified and coordinated for inclusion in a give release with release manager .
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Brad Walker <bw...@musings.com>
Sent: Tuesday, November 29, 2022 12:59:27 PM
To: dev@netbeans.apache.org <de...@netbeans.apache.org>
Subject: Re: average PR merge time
I think the best answer is, it depends..
The fastest response times are for "critical" issues, i.e. defects that
affect a release.
The average response times are about a couple of weeks, maybe even faster.
This is for the "average" issue.
The slowest response times are for issues where the submitter has gone
silent and the pull response might need a little bit of work.
Remember, we are mostly a bunch of volunteers. There is some commercial
support, but not like it once was.
I wish that I had better metrics but I've never seen those nor do I think
they are collected. Though I could be wrong.
Hope this helps.
-brad w.
On Tue, Nov 29, 2022 at 11:05 AM Łukasz Bownik <lu...@gmail.com>
wrote:
> Hi.
> What is the average PR merge/rejection time?
> I see some PRs that are over half a year old.
>
> --
> Łukasz Bownik
>
Re: average PR merge time
Posted by Brad Walker <bw...@musings.com>.
I think the best answer is, it depends..
The fastest response times are for "critical" issues, i.e. defects that
affect a release.
The average response times are about a couple of weeks, maybe even faster.
This is for the "average" issue.
The slowest response times are for issues where the submitter has gone
silent and the pull response might need a little bit of work.
Remember, we are mostly a bunch of volunteers. There is some commercial
support, but not like it once was.
I wish that I had better metrics but I've never seen those nor do I think
they are collected. Though I could be wrong.
Hope this helps.
-brad w.
On Tue, Nov 29, 2022 at 11:05 AM Łukasz Bownik <lu...@gmail.com>
wrote:
> Hi.
> What is the average PR merge/rejection time?
> I see some PRs that are over half a year old.
>
> --
> Łukasz Bownik
>