You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/05/23 21:35:38 UTC
[GitHub] incubator-beam pull request: [BEAM-117] Evaluate display data from...
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/375
[BEAM-117] Evaluate display data from InProcessPipelineRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Display data can be added to any PTransform to be used
for display from any runner. Runners are not required to
consume display data, and currently many don't.
This changes InProcessRunner to consumer display data (and then
discard it) in order to validate that display data is properly
implemented on transforms within a pipeline. Exceptions thrown
within HasDisplayData implementations will cause Pipeline.run()
to fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam displaydata-directrunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit 698a0af1553279ba48ad2f4768556fbd4810208a
Author: Scott Wegner <sw...@google.com>
Date: 2016-05-23T21:29:33Z
Evaluate display data from InProcessPipelineRunner
Display data can be added to any PTransform to be used
for display from any runner. Runners are not required to
consume display data, and currently many don't.
This changes InProcessRunner to consumer display data (and then
discard it) in order to validate that display data is properly
implemented on transforms within a pipeline. Exceptions thrown
within HasDisplayData implementations will cause Pipeline.run()
to fail.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request: [BEAM-117] Evaluate display data from...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---