You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2023/11/21 18:00:20 UTC
[PR] FINERACT-1968: Enhanced charge handling [fineract]
adamsaghy opened a new pull request, #3597:
URL: https://github.com/apache/fineract/pull/3597
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1968: Enhanced charge handling [fineract]
Posted by "reluxa (via GitHub)" <gi...@apache.org>.
reluxa commented on code in PR #3597:
URL: https://github.com/apache/fineract/pull/3597#discussion_r1403330869
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -779,8 +779,10 @@ private void handleChargePaidTransaction(final LoanCharge charge, final LoanTran
.determineProcessor(this.transactionProcessingStrategyCode);
final List<LoanRepaymentScheduleInstallment> chargePaymentInstallments = new ArrayList<>();
List<LoanRepaymentScheduleInstallment> installments = getRepaymentScheduleInstallments();
+ int firstNormalInstallmentNumber = LoanRepaymentScheduleProcessingWrapper
+ .fetchFirstNormalInstallmentNumber(repaymentScheduleInstallments);
for (final LoanRepaymentScheduleInstallment installment : installments) {
- boolean isDue = installment.isFirstPeriod()
+ boolean isDue = installment.getInstallmentNumber().equals(firstNormalInstallmentNumber)
Review Comment:
I know that it was here before, but I was wondering why `isDue` is the proper variable name here. Imo sameInstallment would be more appropriate isn't it, or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1968: Enhanced charge handling [fineract]
Posted by "reluxa (via GitHub)" <gi...@apache.org>.
reluxa commented on code in PR #3597:
URL: https://github.com/apache/fineract/pull/3597#discussion_r1403307690
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/ChargeOrTransaction.java:
##########
@@ -44,14 +44,22 @@ public ChargeOrTransaction(LoanTransaction loanTransaction) {
private LocalDate getEffectiveDate() {
if (loanCharge.isPresent()) {
- return loanCharge.get().getDueDate();
+ if (isBackdatedCharge()) {
Review Comment:
We can add a testcase for this branch to `ChargeOrTransactionTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1968: Enhanced charge handling [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3597:
URL: https://github.com/apache/fineract/pull/3597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org