[GitHub] [nifi] turcsanyip commented on pull request #4843: NIFI-8258: Add support for Service Principal authentication in ADLS p…

[GitBox <gi...@apache.org>]

turcsanyip commented on pull request #4843:
URL: https://github.com/apache/nifi/pull/4843#issuecomment-787532350


   I removed the EL support from the sensitive properties.
   
   I also removed `SSLContextService` and implemented the keystore handling locally but in the end I felt it is something that should rather go into a separate KeyStoreService CS. To leave this question open, I removed the Client Certificate way from this PR and I would handle it in a follow-up ticket.
   You can check the implementation here: https://github.com/turcsanyip/nifi/compare/NIFI-8258...turcsanyip:NIFI-8258_Client_Certificate?expand=1
   I can open another PR from it or we can implement KeyStoreService CS.
   
   Regarding `Authentication Type`: I ran into a bug with `dependsOn()`. Properties depending on the default value of another property (like AUTO in our case) do not show up on the UI initially (when I just created the CS and open the properties tab). 
   I filed a Jira: https://issues.apache.org/jira/browse/NIFI-8270
   I would not wait for this to be fixed and would also implement this `Authentication Type` in a follow-up ticket.
   
   @exceptionfactory, @jfrazee Would it be fine with you to reduce the scope of this PR to Client Secret only? Service Principal with Client Secret is a feature alone. It can be extended with the Client Certificate option and Authentication Type convenience property later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org