You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Elvira Gurevich <El...@ibi.com> on 2003/05/02 23:47:28 UTC
RE: sheet names and string format read garbled on EBCDIC machine
Toshiaki,
Sorry, only now got your e-mail.
If I get a nightly build, would your changes already be there?
If not, how do I get your changes?
Thank you for your help.
Elvira.
-----Original Message-----
From: Toshiaki Kamoshida [mailto:kamoshida.toshiaki@future.co.jp]
Sent: Wednesday, April 23, 2003 11:52 PM
To: POI Developers List
Subject: Re: sheet names and string format read garbled on EBCDIC
machine
Hello,
Mr.Elvira Gurevich,
Perhaps,the focus of this problem has removed(Bug 18947).
But I don't have a env OS/390 (or Solaris/SPARC or HP/UX or...):D
Would you please test current branch on your env,and report the
results? I'm concerned about it...
And if he reports OK,please anynoe close Bug 17791.
I'm sorry,I should submit PATHCES at Bug 17791,instead of entering
New bug.But I didn't know it XP
Thanks.
--------------------------------
Toshiaki Kamoshida
kamoshida.toshiaki@future.co.jp
--------------------------------
On Thu, 10 Apr 2003 13:26:28 +0900
Toshiaki Kamoshida <ka...@future.co.jp> wrote:
> OK,I'll try it.
>
> On Wed, 09 Apr 2003 12:25:02 -0400
> "Andrew C. Oliver" <ac...@apache.org> wrote:
>
> > If you can fix this and supply unit tests it will get done faster.
I'm
> > a bit swamped at the moment.
> >
> > The process is:
> >
> > 1. Change one.
> > 2. Write a unit test for both cases
> > 3. Test
> > 4. See if excel crashes on the result
> > 5. back to #1
> >
> > -Andy
> >
> > Toshiaki Kamoshida wrote:
> >
> > >On Wed, 09 Apr 2003 08:27:52 -0400
> > >"Andrew C. Oliver" <ac...@apache.org> wrote:
> > >
> > >
> > >
> > >>Toshiaki Kamoshida wrote:
> > >>
> > >>
> > >>
> > >>>If you can,there is a way to avoid to be worried about the
problem,
> > >>>
> > >>>1.Serach all phrases
> > >>> "new String(byte[])"or
> > >>> "new String(byte[],int offset,int size)"
> > >>>
> > >>>2.Replace thease phrases to "new String(args,"ISO-8859-1")"
> > >>>
> > >>>
> > >>>
> > >>>
> > >>yes. This is what I did before everywhere that I found it. If
you find
> > >>other places that it should be done, please submit patches/unit
tests/etc.
> > >>
> > >>
> > >>
> > >
> > >I tried grep with
regexp"new[\t\n\x0B\f\r]*String[\t\n\x0B\f\r]*[(]"
> > >in hssf package,and found them.Does this help you?
> > >
> > >record\BoundSheetRecord.java(145): field_5_sheetname =
new String(
> > >data, 8 + offset, nameLength );
> > >record\FontRecord.java(167): field_11_font_name =
new String(data, 16,
> > >record\FooterRecord.java(122): field_2_footer = new
String(data, 3 + offset, // [Shawn] Changed 1 to 3 for offset of string
> > >record\FormatRecord.java(135): field_4_formatstring = new
String(data, 5 + offset, field_3_unicode_len );
> > >record\HeaderRecord.java(122): field_2_header = new
String(data, 3 + offset, // [Shawn] Changed 1 to 3 for offset of string
> > >record\LabelRecord.java(160): field_6_value = new
String(data, 9 + offset, getStringLength());
> > >record\NameRecord.java(759): field_12_name_text = new
String(data, 15 + offset,
> > >record\NameRecord.java(767): field_14_custom_menu_text
= new String(data, start_of_custom_menu_text + offset,
> > >record\NameRecord.java(771): field_15_description_text
= new String(data, start_of_description_text + offset,
> > >record\NameRecord.java(775): field_16_help_topic_text
= new String(data, start_of_help_topic_text + offset,
> > >record\NameRecord.java(779): field_17_status_bar_text
= new String(data, start_of_status_bar_text + offset,
> > >record\StringRecord.java(137): field_3_string = new
String(data, 3 + offset, field_1_string_length);
> > >record\StyleRecord.java(137): field_3_name = new
String(data, 3 + offset,
> > >record\UnicodeString.java(154): field_3_string =
new String(data, 3, getCharCount(),
> > >record\UnicodeString.java(172): field_3_string = new
String(array);
> > >record\UnicodeString.java(303): String unicodeString =
new String(getString().getBytes("Unicode"),"Unicode");
> > >record\WriteAccessRecord.java(118): field_1_username = new
String(data, 3 + offset, data.length - 4);
> > >record\formula\StringPtg.java(82): setValue(new
String(data, offset+3, data[offset+1] + 256*data[offset+2]));
> > >
> > >
> > >
> > >>>I feel,the place using phrases like 1,you expect that byte array
> > >>>contains "ISO-8859-1"(1 char always consumes only 1byte and the
> > >>>charset is Latin-1),and if you must parse byte array as 16Bit
> > >>>Unicode,always you must use StringUtil.
> > >>>And I feel,if the changes like this causes some problems,it is
> > >>>the bug"the place doesn't support i18n" from the beginning.
> > >>>
> > >>>
> > >>>
> > >>>
> > >>yes/no we should support i18n.
> > >>
> > >>
> > >
> > >OK,of course,if a bug appears we must fix it:D
> > >
> > >
> > >
> > >>>But,can you change sources without appearing sickness?
> > >>>Is the way "too rough"?
> > >>>
> > >>>
> > >>>
> > >>>
> > >>This is opensource. We can always patch. I don't worry about
appearences.
> > >>
> > >>
> > >
> > >OK,I understand.
> > >
> > >
> > >
> > >>-Andy
> > >>
> > >>
> > >>
> > >(omit)
> > >
> > >Thanks.
> > >
> > >Toshiaki Kamoshida
> > >
> > >
> >
>---------------------------------------------------------------------
> > >To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>
> --------------------------------
>
> Toshiaki Kamoshida
> kamoshida.toshiaki@future.co.jp
>
> --------------------------------
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: poi-dev-help@jakarta.apache.org
Re: sheet names and string format read garbled on EBCDIC
machine
Posted by Glen Stampoultzis <gs...@iinet.net.au>.
At 05:05 AM 5/05/2003, you wrote:
> > What exactly are you referring to?
>
>Now I'm referring
>anoncvs@cvs.apache.org:/home/cvspublic/jakarta-poi
>
>Now,line feeds has lost in some sources at here.
>Some of these disturb to complie are fixed by Mr Andy,but others
>are not.
I believe Andy committed a fix for that one. It was actually my commit
that caused the problem however I'm not sure what's triggering it. I'm
watching my commits more carefully now and if it happens again (it seems to
happen at commit time) I'll correct it straight away.
Glen Stampoultzis
gstamp@iinet.net.au
http://members.iinet.net.au/~gstamp/glen/
Re: sheet names and string format read garbled on EBCDIC machine
Posted by Toshiaki Kamoshida <tk...@hh.iij4u.or.jp>.
On 04 May 2003 22:34:18 +0530
Avik Sengupta <av...@apache.org> wrote:
> > But,now some sources at CVSROOT/jakarta-poi is a little corrupted,
> > so please wait a moment until someone will fix it...
>
> What exactly are you referring to?
Now I'm referring
anoncvs@cvs.apache.org:/home/cvspublic/jakarta-poi
Now,line feeds has lost in some sources at here.
Some of these disturb to complie are fixed by Mr Andy,but others
are not.
I found;
src/java/org/apache/poi/hssf/record/ExternSeetRecord
src/java/org/apache/poi/util/StringUtil
src/java/org/apache/poi/util/HexRead
src/java/org/apache/poi/hssf/usermodel/HSSFPrintSetup
Maybe more,but I don't know XP
Now build task will pass without fix these.
So perhaps we can test the latest sources.But I can't assert it...
Thanks.
>
> On Sun, 2003-05-04 at 22:21, Toshiaki Kamoshida wrote:
> > Hello,
> >
> > Now I get your responce...
> > (In Japan,the last week is "Golden-Week" means "Holiday-Week":D)
> >
> > Please get CVS HEAD branch of jakarta-poi and make in your locale env.
> > There is Build.xml(for Ant) to make libs etc at root directory.
> > (Lately Mr.Glen works hard about it. Thanks,it is very useful for me)
> >
> > How to get current sources from CVS server:
> > http://jakarta.apache.org/site/cvsindex.html
> >
> > But,now some sources at CVSROOT/jakarta-poi is a little corrupted,
> > so please wait a moment until someone will fix it...
> >
> > Thanks.
> >
> > On Fri, 2 May 2003 17:47:28 -0400
> > "Elvira Gurevich" <El...@ibi.com> wrote:
> >
> > > Toshiaki,
> > >
> > > Sorry, only now got your e-mail.
> > >
> > > If I get a nightly build, would your changes already be there?
> > > If not, how do I get your changes?
> > >
> > > Thank you for your help.
> > > Elvira.
> > >
> > >
> > > -----Original Message-----
> > > From: Toshiaki Kamoshida [mailto:kamoshida.toshiaki@future.co.jp]
> > > Sent: Wednesday, April 23, 2003 11:52 PM
> > > To: POI Developers List
> > > Subject: Re: sheet names and string format read garbled on EBCDIC
> > > machine
> > >
> > > Hello,
> > >
> > > Mr.Elvira Gurevich,
> > > Perhaps,the focus of this problem has removed(Bug 18947).
> > >
> > > But I don't have a env OS/390 (or Solaris/SPARC or HP/UX or...):D
> > > Would you please test current branch on your env,and report the
> > > results? I'm concerned about it...
> > >
> > > And if he reports OK,please anynoe close Bug 17791.
> > > I'm sorry,I should submit PATHCES at Bug 17791,instead of entering
> > > New bug.But I didn't know it XP
> > >
> > > Thanks.
> > >
> > > --------------------------------
> > >
> > > Toshiaki Kamoshida
> > > kamoshida.toshiaki@future.co.jp
> > >
> > > --------------------------------
> > >
> > (omit)
> >
> > ---------------------------------
> >
> > Toshiaki Kamoshida
> > Mail: tkamo@hh.iij4u.or.jp
> >
> > ---------------------------------
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: poi-dev-help@jakarta.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
---------------------------------
Toshiaki Kamoshida
Mail: tkamo@hh.iij4u.or.jp
---------------------------------
Re: sheet names and string format read garbled on EBCDIC machine
Posted by Avik Sengupta <av...@apache.org>.
> But,now some sources at CVSROOT/jakarta-poi is a little corrupted,
> so please wait a moment until someone will fix it...
What exactly are you referring to?
On Sun, 2003-05-04 at 22:21, Toshiaki Kamoshida wrote:
> Hello,
>
> Now I get your responce...
> (In Japan,the last week is "Golden-Week" means "Holiday-Week":D)
>
> Please get CVS HEAD branch of jakarta-poi and make in your locale env.
> There is Build.xml(for Ant) to make libs etc at root directory.
> (Lately Mr.Glen works hard about it. Thanks,it is very useful for me)
>
> How to get current sources from CVS server:
> http://jakarta.apache.org/site/cvsindex.html
>
> But,now some sources at CVSROOT/jakarta-poi is a little corrupted,
> so please wait a moment until someone will fix it...
>
> Thanks.
>
> On Fri, 2 May 2003 17:47:28 -0400
> "Elvira Gurevich" <El...@ibi.com> wrote:
>
> > Toshiaki,
> >
> > Sorry, only now got your e-mail.
> >
> > If I get a nightly build, would your changes already be there?
> > If not, how do I get your changes?
> >
> > Thank you for your help.
> > Elvira.
> >
> >
> > -----Original Message-----
> > From: Toshiaki Kamoshida [mailto:kamoshida.toshiaki@future.co.jp]
> > Sent: Wednesday, April 23, 2003 11:52 PM
> > To: POI Developers List
> > Subject: Re: sheet names and string format read garbled on EBCDIC
> > machine
> >
> > Hello,
> >
> > Mr.Elvira Gurevich,
> > Perhaps,the focus of this problem has removed(Bug 18947).
> >
> > But I don't have a env OS/390 (or Solaris/SPARC or HP/UX or...):D
> > Would you please test current branch on your env,and report the
> > results? I'm concerned about it...
> >
> > And if he reports OK,please anynoe close Bug 17791.
> > I'm sorry,I should submit PATHCES at Bug 17791,instead of entering
> > New bug.But I didn't know it XP
> >
> > Thanks.
> >
> > --------------------------------
> >
> > Toshiaki Kamoshida
> > kamoshida.toshiaki@future.co.jp
> >
> > --------------------------------
> >
> (omit)
>
> ---------------------------------
>
> Toshiaki Kamoshida
> Mail: tkamo@hh.iij4u.or.jp
>
> ---------------------------------
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>
Re: sheet names and string format read garbled on EBCDIC machine
Posted by Toshiaki Kamoshida <tk...@hh.iij4u.or.jp>.
Hello,
Now I get your responce...
(In Japan,the last week is "Golden-Week" means "Holiday-Week":D)
Please get CVS HEAD branch of jakarta-poi and make in your locale env.
There is Build.xml(for Ant) to make libs etc at root directory.
(Lately Mr.Glen works hard about it. Thanks,it is very useful for me)
How to get current sources from CVS server:
http://jakarta.apache.org/site/cvsindex.html
But,now some sources at CVSROOT/jakarta-poi is a little corrupted,
so please wait a moment until someone will fix it...
Thanks.
On Fri, 2 May 2003 17:47:28 -0400
"Elvira Gurevich" <El...@ibi.com> wrote:
> Toshiaki,
>
> Sorry, only now got your e-mail.
>
> If I get a nightly build, would your changes already be there?
> If not, how do I get your changes?
>
> Thank you for your help.
> Elvira.
>
>
> -----Original Message-----
> From: Toshiaki Kamoshida [mailto:kamoshida.toshiaki@future.co.jp]
> Sent: Wednesday, April 23, 2003 11:52 PM
> To: POI Developers List
> Subject: Re: sheet names and string format read garbled on EBCDIC
> machine
>
> Hello,
>
> Mr.Elvira Gurevich,
> Perhaps,the focus of this problem has removed(Bug 18947).
>
> But I don't have a env OS/390 (or Solaris/SPARC or HP/UX or...):D
> Would you please test current branch on your env,and report the
> results? I'm concerned about it...
>
> And if he reports OK,please anynoe close Bug 17791.
> I'm sorry,I should submit PATHCES at Bug 17791,instead of entering
> New bug.But I didn't know it XP
>
> Thanks.
>
> --------------------------------
>
> Toshiaki Kamoshida
> kamoshida.toshiaki@future.co.jp
>
> --------------------------------
>
(omit)
---------------------------------
Toshiaki Kamoshida
Mail: tkamo@hh.iij4u.or.jp
---------------------------------