You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/18 09:45:09 UTC

[GitHub] [pulsar] liangyepianzhou commented on issue #18957: PIP-230: Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

liangyepianzhou commented on issue #18957:
URL: https://github.com/apache/pulsar/issues/18957#issuecomment-1356759691

   > now when BatchMessageIdImpl and MessageIdImpl with the sameLedgerId and EntryId, one of it compared with the other, theBatchMessageIdImpl will always be greater than MessageIdImpl.
   
   Sorry, I can not understand this case.
   Why do there exist MessageID and BatchMessageID with the same ledgerID, entryID, and partitionIndex?
   
   > change current `MessageIdImpl` and `BatchMessageIdImpl` compareTo() logic as the same as https://github.com/apache/pulsar/blob/a35670d83b0b3f2fb63d11e4fb222d7f24099c9a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L665-L681
   
   And why it is right that the MessageID is always bigger than the BatchMessageID?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org