[jira] [Commented] (SUREFIRE-2250) Surefire Test Report Schema properties element is not consistent with the code

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863528#comment-17863528 ] 

ASF GitHub Bot commented on SUREFIRE-2250:
------------------------------------------

michael-o opened a new pull request, #758:
URL: https://github.com/apache/maven-surefire/pull/758

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   




> Surefire Test Report Schema properties element is not consistent with the code
> ------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-2250
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2250
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: xml generation
>    Affects Versions: 3.3.0
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.3.1
>
>
> surefire-test-report.xsd defines:
> {code:xml}
> <xs:element name="properties" minOccurs="0" maxOccurs="unbounded">
> {code}
> but the Java code says:
> {code}
>     private static void showProperties(XMLWriter xmlWriter, Map<String, String> systemProperties) throws IOException {
>         xmlWriter.startElement("properties");
>         for (final Entry<String, String> entry : systemProperties.entrySet()) {
>             final String key = entry.getKey();
>             String value = entry.getValue();
>             if (value == null) {
>                 value = "null";
>             }
>             xmlWriter.startElement("property");
>             xmlWriter.addAttribute("name", key);
>             xmlWriter.addAttribute("value", extraEscapeAttribute(value));
>             xmlWriter.endElement();
>         }
>         xmlWriter.endElement();
>     }
> {code}
> and is called only once in {{org.apache.maven.plugin.surefire.report.StatelessXmlReporter.testSetCompleted(WrappedReportEntry, TestSetStats)}}. This makes the schema definition wrong. Let's fix this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)