You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/03/24 14:56:13 UTC

[GitHub] [drill] cgivre commented on a change in pull request #2483: DRILL-8149: large xlsx configs

cgivre commented on a change in pull request #2483:
URL: https://github.com/apache/drill/pull/2483#discussion_r834400430



##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -183,6 +189,9 @@ public String getFieldName() {
       lastColumn = plugin.getConfig().getLastColumn();
       allTextMode = plugin.getConfig().getAllTextMode();
       sheetName = plugin.getConfig().getSheetName();
+      maxArraySize = plugin.getConfig().getMaxArraySize();

Review comment:
       @pjfanning Thanks for the update!   Can you update the `README` file in this folder to explain what these options do?  Do you have recommended values?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org