You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2015/05/26 21:29:55 UTC
[GitHub] incubator-streams pull request: resolves STREAMS-332 #332
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/226
resolves STREAMS-332 #332
changed tests without resources to ITs
ITs do not run by default, must run verify -skipTests=false
added retrieval and expansion of zip files containing test resources
location of zip files can be overridden with -testDataBaseURL
original test files have been restored to an externally hosted location
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-332
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 3f45b23ebb63aeddb1badc2100599292a7b52170
Author: Steve Blackmon (@steveblackmon) <sb...@apache.org>
Date: 2015-05-26T18:38:09Z
changed tests without resources to ITs
ITs do not run by default, must run verify -skipTests=false
added retrieval and expansion of zip files containing test resources
location of zip files can be overridden with -testDataBaseURL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-332 #332
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-332 #332
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/226#issuecomment-112557980
I will lazy consensus merge this in 48 hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-332 #332
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/226#discussion_r31985768
--- Diff: streams-contrib/streams-provider-datasift/pom.xml ---
@@ -29,6 +29,11 @@
<description>Datasift Provider</description>
+ <properties>
+ <skipITs>true</skipITs>
+ <testDataBaseURl>http://streams.peoplepattern.com.s3.amazonaws.com/test-data/</testDataBaseURl>
--- End diff --
Yes - these reference test files can reside in this commerically-hosted repository with public permissions until/unless there is a complaint. More important than where these specific test files are hosted today, integration tests can now run against real-world data hosted by anyone at any accessible URL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-332 #332
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/226#issuecomment-117777504
realized this was closed with out merging - merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves STREAMS-332 #332
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/226#discussion_r31368164
--- Diff: streams-contrib/streams-provider-datasift/pom.xml ---
@@ -29,6 +29,11 @@
<description>Datasift Provider</description>
+ <properties>
+ <skipITs>true</skipITs>
+ <testDataBaseURl>http://streams.peoplepattern.com.s3.amazonaws.com/test-data/</testDataBaseURl>
--- End diff --
@steveblackmon Did you intend for this URI and the other ones below to be committed here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---