[jira] [Reopened] (OFBIZ-5818) Removal of unapplied code from ProjectMgr secas.xml

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-5818:
------------------------------------

> Removal of unapplied code from ProjectMgr secas.xml
> ---------------------------------------------------
>
>                 Key: OFBIZ-5818
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5818
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/projectmgr
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-5818-ProjectMgrDeadCodeRemoval.patch
>
>
> This is related to http://ofbiz.markmail.org/message/b6n2fa5prwiekgcv?q=checkProjectMembership
> I did a check in viewvc and the functionality in secas.xml regarding 'updateTaskAssignment' was commented out in commit 706506 (5 years ago), see http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/servicedef/secas.xml?revision=706506&view=markup&pathrev=706506
> as part of a set of changes by Hans, see http://svn.apache.org/viewvc?view=revision&revision=706506
> Unfortunately no clues (other than the comment line in the file) were provided as to what the circumstances where that lead to the conclusion and the disablement of the service.
> I also did a search on whether 'updateTaskAssignment' was referenced anywhere else in the code of the ProjectMgr component, and everywhere else, and this is what I found:
> * it has a definition in servicedef.xml, pointing to a simple service in file ProjectServices.xml
> * it is referenced in the controller.xml and in TaskForms.xml
> * it is referenced in the controller.xml of the SFA application pointing to the service of ProjectMgr.
> I also did a search in JIRA whether both 'checkProjectMembership and 'updateTaskAssigment occured, but could not find an issue. 
> It seems to me that this is some kind of forgotten leftover of a code change.
> I will create a patch to remove the commented out code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)