You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/09/16 05:42:05 UTC
[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4437
Change subject: [client-test] faster TestFlushModesCompareOpRates*
......................................................................
[client-test] faster TestFlushModesCompareOpRates*
Use smaller mutation buffer size and apply fewer write operations
in TestFlushModesCompareOpRates{FixedSize, RandomSize} tests.
This makes then run significantly faster in ASAN and TSAN builds.
Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
---
M src/kudu/client/client-test.cc
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4437/1
--
To view, visit http://gerrit.cloudera.org:8080/4437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [client-test] faster TestFlushModesCompareOpRates*
......................................................................
[client-test] faster TestFlushModesCompareOpRates*
Use smaller mutation buffer size and apply fewer write operations
in TestFlushModesCompareOpRates{FixedSize, RandomSize} tests.
This makes then run significantly faster in ASAN and TSAN builds.
Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Reviewed-on: http://gerrit.cloudera.org:8080/4437
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client-test.cc
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [client-test] faster TestFlushModesCompareOpRates*
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 2269: ASSERT_OK(session->SetMutationBufferFlushWatermark(0.5));
: ASSERT_OK(session->SetMutationBufferMaxNum(2));
Aren't these the default values?
--
To view, visit http://gerrit.cloudera.org:8080/4437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [client-test] faster TestFlushModesCompareOpRates*
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 2269: ASSERT_OK(session->SetMutationBufferFlushWatermark(0.5));
: ASSERT_OK(session->SetMutationBufferMaxNum(2));
> Yes, they are. My concern was to have this test working even if we change
I think it's fine to keep.
--
To view, visit http://gerrit.cloudera.org:8080/4437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client-test] faster TestFlushModesCompareOpRates*
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 2269: ASSERT_OK(session->SetMutationBufferFlushWatermark(0.5));
: ASSERT_OK(session->SetMutationBufferMaxNum(2));
> Aren't these the default values?
Yes, they are. My concern was to have this test working even if we change the defaults. If changing flush watermark, the margin becomes thinner.
BTW, I started thinking about removing these two tests at all. :)
From one side, it's good to have a test which verifies that AUTO_FLUSH_BACKGROUND works faster because it does not incur penalty for flushing every single write operation. From the other side, should it be a unit test?
What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/4437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d260ac87b2daecbc97803a4663e80978b65b8f1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes