You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2011/08/12 01:35:43 UTC
Review Request: Change the GET_PREFERENCES api to be asynchronous
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
Change the GET_PREFERENCES api to be asynchronous
This addresses bug SHINDIG-1568.
https://issues.apache.org/jira/browse/SHINDIG-1568
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
Diff: https://reviews.apache.org/r/1476/diff
Testing
-------
Thanks,
Dan
Re: Review Request: Change the GET_PREFERENCES api to be asynchronous
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1455
-----------------------------------------------------------
Ship it!
Committed revision 1157893.
- Ryan
On 2011-08-11 23:35:43, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1476/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 23:35:43)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
>
> Change the GET_PREFERENCES api to be asynchronous
>
>
> This addresses bug SHINDIG-1568.
> https://issues.apache.org/jira/browse/SHINDIG-1568
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
>
> Diff: https://reviews.apache.org/r/1476/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Change the GET_PREFERENCES api to be asynchronous
Posted by Jesse Ciancetta <jc...@mitre.org>.
> On 2011-08-12 00:37:02, Ryan Baxter wrote:
> >
>
> Dan Dumont wrote:
> The spec declared the 2 common container config params (set/get) to be optional. It's not necessary to use them.
> However, since fetching preferences is such a common task for containers it seemed nice to provide this optional convenience to containers.
>
> I did not want to make it mandatory, so you'll note that if you supply the preferences in the renderParams, they will be used instead.
>
> Ryan Baxter wrote:
> Ok I can buy that, as long as its up to the container to decide what it wants to do I am fine with providing both methods. Jesse, does this sound OK to you?
Yes -- sounds good to me too. I didn't realize a formal spec had actually been written around the common container, that's great to see. I knew there were some discussions of it but I hadn't actually seen it yet. Now that I've read over the spec a bit this makes more sense to me.
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
On 2011-08-11 23:35:43, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1476/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 23:35:43)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
>
> Change the GET_PREFERENCES api to be asynchronous
>
>
> This addresses bug SHINDIG-1568.
> https://issues.apache.org/jira/browse/SHINDIG-1568
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
>
> Diff: https://reviews.apache.org/r/1476/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Change the GET_PREFERENCES api to be asynchronous
Posted by Dan Dumont <dd...@us.ibm.com>.
> On 2011-08-12 00:37:02, Ryan Baxter wrote:
> >
The spec declared the 2 common container config params (set/get) to be optional. It's not necessary to use them.
However, since fetching preferences is such a common task for containers it seemed nice to provide this optional convenience to containers.
I did not want to make it mandatory, so you'll note that if you supply the preferences in the renderParams, they will be used instead.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
On 2011-08-11 23:35:43, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1476/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 23:35:43)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
>
> Change the GET_PREFERENCES api to be asynchronous
>
>
> This addresses bug SHINDIG-1568.
> https://issues.apache.org/jira/browse/SHINDIG-1568
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
>
> Diff: https://reviews.apache.org/r/1476/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Change the GET_PREFERENCES api to be asynchronous
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-08-12 00:37:02, Ryan Baxter wrote:
> >
>
> Dan Dumont wrote:
> The spec declared the 2 common container config params (set/get) to be optional. It's not necessary to use them.
> However, since fetching preferences is such a common task for containers it seemed nice to provide this optional convenience to containers.
>
> I did not want to make it mandatory, so you'll note that if you supply the preferences in the renderParams, they will be used instead.
Ok I can buy that, as long as its up to the container to decide what it wants to do I am fine with providing both methods. Jesse, does this sound OK to you?
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
On 2011-08-11 23:35:43, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1476/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 23:35:43)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
>
> Change the GET_PREFERENCES api to be asynchronous
>
>
> This addresses bug SHINDIG-1568.
> https://issues.apache.org/jira/browse/SHINDIG-1568
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
>
> Diff: https://reviews.apache.org/r/1476/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Change the GET_PREFERENCES api to be asynchronous
Posted by Jesse Ciancetta <jc...@mitre.org>.
> On 2011-08-12 00:37:02, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, line 223
> > <https://reviews.apache.org/r/1476/diff/2/?file=32304#file32304line223>
> >
> > Maybe I should have looked at this functionality earlier but I am struggling to grasp this 'listener' functionality to get the preferences when navigating to the gadget. Why wouldn't the container get the preferences before they call navigate gadget and just stick them in renderParams when calling navigateGadget?
I agree with Ryan's comment -- this doesn't seem like it should be necessary. We actually use the approach Ryan is describing already in Rave and I can confirm that it works just fine.
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
On 2011-08-11 23:35:43, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1476/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 23:35:43)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
>
> Change the GET_PREFERENCES api to be asynchronous
>
>
> This addresses bug SHINDIG-1568.
> https://issues.apache.org/jira/browse/SHINDIG-1568
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
>
> Diff: https://reviews.apache.org/r/1476/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Change the GET_PREFERENCES api to be asynchronous
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1476/#review1413
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/1476/#comment3268>
Maybe I should have looked at this functionality earlier but I am struggling to grasp this 'listener' functionality to get the preferences when navigating to the gadget. Why wouldn't the container get the preferences before they call navigate gadget and just stick them in renderParams when calling navigateGadget?
- Ryan
On 2011-08-11 23:35:43, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1476/
> -----------------------------------------------------------
>
> (Updated 2011-08-11 23:35:43)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Spec Change: http://code.google.com/p/opensocial-resources/issues/detail?id=1203
>
> Change the GET_PREFERENCES api to be asynchronous
>
>
> This addresses bug SHINDIG-1568.
> https://issues.apache.org/jira/browse/SHINDIG-1568
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1156829
>
> Diff: https://reviews.apache.org/r/1476/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>