You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2015/12/10 16:13:08 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

GitHub user remibergsma opened a pull request:

    https://github.com/apache/cloudstack/pull/1213

    CLOUDSTACK-9137 Allow domain admin to manage private gw

    To create a private gateway you need a root admin account. This does not make sense, as you can do a lot more with such a powerful account. Other network related API calls can be made by a domain admin.
    
    This PR allows domain admins to create their own private gateways.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remibergsma/cloudstack private_gw_domain_admin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1213
    
----
commit e9b5b8f55d100f67146bd03b6b7577bd0660d155
Author: Remi Bergsma <gi...@remi.nl>
Date:   2015-12-10T15:09:26Z

    CLOUDSTACK-9137 Allow domain admin to manage priv gw

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma closed the pull request at:

    https://github.com/apache/cloudstack/pull/1213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1213#issuecomment-163683468
  
    It seems this is more complex than it seemed. Since we've to put in a 'physical network id' (which is obviously owned by ROOT domain, this does not work yet.
    
    Creating fails:
    ```
    (admin) 🐵 > create privategateway gateway=1.2.3.4 ipaddress=4.3.2.1 netmask=255.255.255.0 vpcid=cc80ae2c-c3ad-4ea3-96f4-dc40970c81e4 vlan="lswitch://uuid"
    Error 531: Acct[74caa349-7f41-4e1a-b4b1-d386c0c2a1a2-rbergsma] does not have permission to operate within domain id=9c2baf29-9846-11e5-9afa-525400b8977a
    cserrorcode = 4365
    errorcode = 531
    errortext = Acct[74caa349-7f41-4e1a-b4b1-d386c0c2a1a2-rbergsma] does not have permission to operate within domain id=9c2baf29-9846-11e5-9afa-525400b8977a
    uuidList:
    ```
    
    This is the mentioned domain id:
    
    ```
    (admin) 🐵 > set profile root
    (root) 🐵 > list domains id=9c2baf29-9846-11e5-9afa-525400b8977a filter=name
    count = 1
    domain:
    name = ROOT
    ```
    
    Most likely due to the physical network id. Hmm..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1213#issuecomment-163674707
  
    @remibergsma Can domain admin1 delete gateway created by domain admin2? If the existing code is properly handling these scenarios then fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---