You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/09/05 14:32:13 UTC
Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and
firewall rules issues after KVM upgrade to 4.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Bugs: CLOUDSTACK-4405
Repository: cloudstack-git
Description
-------
There still exist two issues after Edison's commits.
(1) Migration from new hosts to old hosts failed.
The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
(2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
Diffs
-----
agent/bindir/cloudstack-agent-upgrade.in 4972d39
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
scripts/vm/network/security_group.py 0ac8b74
Diff: https://reviews.apache.org/r/13992/diff/
Testing
-------
tested ok on my environment.
After this, the KVM upgrade steps :
a. Install 4.2 cloudstack agent on each kvm host
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
c5. service cloudstack-agent restart
Thanks,
Wei Zhou
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review25939
-----------------------------------------------------------
Thanks for your fix on iptables, patch is OK for me.
- edison su
On Sept. 5, 2013, 12:32 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26346
-----------------------------------------------------------
Commit 258118efa67b426611dc87c66b4891924641772b in branch refs/heads/master from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=258118e ]
CLOUDSTACK-4405: additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
There still exist two issues after Edison's commits.
(1) Migration from new hosts to old hosts failed.
The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
(2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
After this, the KVM upgrade steps :
a. Install 4.2 cloudstack agent on each kvm host
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
c5. service cloudstack-agent restart
Signed-off-by: Wei Zhou <w....@leaseweb.com>
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26345
-----------------------------------------------------------
Commit 164e3e33b414861d4c49457df66dbd7a73830303 in branch refs/heads/master from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=164e3e3 ]
CLOUDSTACK-4405: change rpm and debian packaging to support automatic update (KVM upgrade)
Including following steps:
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
(cherry picked from commit a0988780ad88bb56becb0a13efedcd79c1bee142)
Signed-off-by: Wei Zhou <w....@leaseweb.com>
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26347
-----------------------------------------------------------
Commit e325fb66ab1fa0796ade6b5d3d70c688b57e5409 in branch refs/heads/master from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e325fb6 ]
CLOUDSTACK-4405: fix vm migration during the upgrade to 4.2
Signed-off-by: Wei Zhou <w....@leaseweb.com>
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26344
-----------------------------------------------------------
Commit a0988780ad88bb56becb0a13efedcd79c1bee142 in branch refs/heads/4.2-forward from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a098878 ]
CLOUDSTACK-4405: change rpm and debian packaging to support automatic update (KVM upgrade)
Including following steps:
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26343
-----------------------------------------------------------
Commit 175549f3ab952bbd39318c16c269c16526255475 in branch refs/heads/4.2-forward from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=175549f ]
CLOUDSTACK-4405: additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
There still exist two issues after Edison's commits.
(1) Migration from new hosts to old hosts failed.
The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
(2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
After this, the KVM upgrade steps :
a. Install 4.2 cloudstack agent on each kvm host
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
c5. service cloudstack-agent restart
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26348
-----------------------------------------------------------
Commit 7b4f84622051b532a7e272dc1ed87310ea119cbc in branch refs/heads/master from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7b4f846 ]
CLOUDSTACK-4405: add a tool: cloudstack-agent-upgrade to upgrade bridge name on kvm host
(cherry picked from commit 0ef6084d2c838a78eda29d258b1af98df96451b3)
Signed-off-by: Wei Zhou <w....@leaseweb.com>
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review26372
-----------------------------------------------------------
Commit 164e3e33b414861d4c49457df66dbd7a73830303 in branch refs/heads/disk-cache from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=164e3e3 ]
CLOUDSTACK-4405: change rpm and debian packaging to support automatic update (KVM upgrade)
Including following steps:
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
(cherry picked from commit a0988780ad88bb56becb0a13efedcd79c1bee142)
Signed-off-by: Wei Zhou <w....@leaseweb.com>
- ASF Subversion and Git Services
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for
bridge name and firewall rules issues after KVM upgrade to 4.2
Posted by Daan Hoogland <da...@gmail.com>.
please go ahead, I will change BridgeVifDriver as per
https://reviews.apache.org/r/13934. i see no conflicts
On Wed, Sep 18, 2013 at 3:48 PM, Wei Zhou <w....@leaseweb.com> wrote:
>
>
>> On Sept. 9, 2013, 2:34 p.m., Wei Zhou wrote:
>> > please ignore the r2 version for issue CLOUDSTACK-3565
>
> CLOUDSTACK-3565 is fixed, so I will commit r2 version if nobody objects.
>
>
> - Wei
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/#review25989
> -----------------------------------------------------------
>
>
> On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/13992/
>> -----------------------------------------------------------
>>
>> (Updated Sept. 9, 2013, 8:09 a.m.)
>>
>>
>> Review request for cloudstack and edison su.
>>
>>
>> Bugs: CLOUDSTACK-4405
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> There still exist two issues after Edison's commits.
>> (1) Migration from new hosts to old hosts failed.
>> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>>
>> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>>
>>
>> Diffs
>> -----
>>
>> agent/bindir/cloudstack-agent-upgrade.in 4972d39
>> debian/cloudstack-agent.postinst 499ae6a
>> debian/rules 5e3d58c
>> packaging/centos63/cloud.spec 2b814f8
>> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
>> scripts/vm/network/security_group.py 0ac8b74
>>
>> Diff: https://reviews.apache.org/r/13992/diff/
>>
>>
>> Testing
>> -------
>>
>> tested ok on my environment.
>>
>> After this, the KVM upgrade steps :
>> a. Install 4.2 cloudstack agent on each kvm host
>> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
>> c. install a libvirt hook:
>> c1. mkdir /etc/libvirt/hooks
>> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
>> c3. chmod +x /etc/libvirt/hooks/qemu
>> c4. service libvirtd restart
>> c5. service cloudstack-agent restart
>>
>>
>> Thanks,
>>
>> Wei Zhou
>>
>>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by Wei Zhou <w....@leaseweb.com>.
> On Sept. 9, 2013, 2:34 p.m., Wei Zhou wrote:
> > please ignore the r2 version for issue CLOUDSTACK-3565
CLOUDSTACK-3565 is fixed, so I will commit r2 version if nobody objects.
- Wei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review25989
-----------------------------------------------------------
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/#review25989
-----------------------------------------------------------
please ignore the r2 version for issue CLOUDSTACK-3565
- Wei Zhou
On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13992/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Bugs: CLOUDSTACK-4405
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There still exist two issues after Edison's commits.
> (1) Migration from new hosts to old hosts failed.
> The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
>
> (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
>
>
> Diffs
> -----
>
> agent/bindir/cloudstack-agent-upgrade.in 4972d39
> debian/cloudstack-agent.postinst 499ae6a
> debian/rules 5e3d58c
> packaging/centos63/cloud.spec 2b814f8
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
> scripts/vm/network/security_group.py 0ac8b74
>
> Diff: https://reviews.apache.org/r/13992/diff/
>
>
> Testing
> -------
>
> tested ok on my environment.
>
> After this, the KVM upgrade steps :
> a. Install 4.2 cloudstack agent on each kvm host
> b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
> c. install a libvirt hook:
> c1. mkdir /etc/libvirt/hooks
> c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
> c3. chmod +x /etc/libvirt/hooks/qemu
> c4. service libvirtd restart
> c5. service cloudstack-agent restart
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name
and firewall rules issues after KVM upgrade to 4.2
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13992/
-----------------------------------------------------------
(Updated Sept. 9, 2013, 8:09 a.m.)
Review request for cloudstack and edison su.
Changes
-------
(3) change rpm and debian packaging to support automatic update (c1-c4)
Testing ok in CentOS and Ubuntu installation.
Bugs: CLOUDSTACK-4405
Repository: cloudstack-git
Description
-------
There still exist two issues after Edison's commits.
(1) Migration from new hosts to old hosts failed.
The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade.
(2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade.
Diffs (updated)
-----
agent/bindir/cloudstack-agent-upgrade.in 4972d39
debian/cloudstack-agent.postinst 499ae6a
debian/rules 5e3d58c
packaging/centos63/cloud.spec 2b814f8
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e3779a7
scripts/vm/network/security_group.py 0ac8b74
Diff: https://reviews.apache.org/r/13992/diff/
Testing
-------
tested ok on my environment.
After this, the KVM upgrade steps :
a. Install 4.2 cloudstack agent on each kvm host
b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules.
c. install a libvirt hook:
c1. mkdir /etc/libvirt/hooks
c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu
c3. chmod +x /etc/libvirt/hooks/qemu
c4. service libvirtd restart
c5. service cloudstack-agent restart
Thanks,
Wei Zhou