You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/01 17:57:14 UTC

[GitHub] [spark] sunchao commented on a change in pull request #35378: [SPARK-38077][SQL] Fix binary compatibility issue with isDeterministic flag

sunchao commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r796857200



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -371,6 +384,18 @@ case class Invoke(
     }
 
   private lazy val encodedFunctionName = ScalaReflection.encodeFieldNameToIdentifier(functionName)
+  private var isDeterministic: Boolean = true

Review comment:
       Ah cool, this is neat. Let me switch to use this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org