[GitHub] [skywalking-query-protocol] wu-sheng commented on a diff in pull request #102: Define the eBPF network sampling strategy

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #102:
URL: https://github.com/apache/skywalking-query-protocol/pull/102#discussion_r1024178538


##########
ebpf-profiling.graphqls:
##########
@@ -30,10 +30,45 @@ input EBPFProfilingTaskFixedTimeCreationRequest {
     targetType: EBPFProfilingTargetType!
 }
 
+input EBPFNetworkDataCollectingSettings {
+    # Require to collect the complete request
+    requireCompleteRequest: Boolean!
+    # The max size of request context. The unit is byte.
+    # Collect the whole request header and body if this is not set.
+    maxRequestSize: Int
+
+    # Require to collect the complete response
+    requireCompleteResponse: Boolean!
+    # The max size of response context. The unit is byte.
+    # Collect the whole response header and body if this is not set.
+    maxResponseSize: Int
+}
+
+input EBPFNetworkSamplingRule {
+    # The match pattern for HTTP request. This is HTTP URI-oriented.
+    # matches all requests if not set
+    uriRegex: String
+
+    # the minimal request duration to activate the network data(HTTP request/response raw data) sampling.
+    # Collecting requests without minimal request duration
+    minDuration: Int
+    # Collecting requests when the response code is 400-499
+    when4xx: Boolean!
+    # Collecting requests when the response code is 500-599
+    when5xx: Boolean!

Review Comment:
   `minDuration` condition could work when `when5xx` or `when4xx` matched. If neither of them is set, `minDuration` works on its own.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org