You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/22 10:49:07 UTC
[GitHub] [shardingsphere] klboke opened a new pull request #5760: Optimized aes encryption implementation
klboke opened a new pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760
Changes proposed in this pull request:
1、Modified the implementation of AESEncryptor, moved the instantiation and initialization of AES encryption and decryption to init, without having to initialize it every time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] klboke commented on pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
klboke commented on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632990463
I found that I have to mention pr again to solve the problem of code formatting, right? The code format verification problem has actually been fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yu199195 commented on pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632982921
@klboke hi，you pr changed a few lines that you did not change ，you can not format this code，blank line may be 4 characters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632984252
Hi @klbokkl, thanks for your first contribution to ShardingSphere community, welcome! :)
I reviewed your PR, and it looks great to avoid initializing encryptor repeatedly. However, like @yu199195 said, checking style is required, since your code is public to anyone all over the world.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] klboke commented on pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
klboke commented on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632988638
I have noticed the problem of formatting IDEA code, I will resubmit it after modification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kezhenxu94 edited a comment on pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632988254
The code style "keep indentation in blank lines" is a little bit unfriendly for new-comers (like me, at https://github.com/apache/shardingsphere/pull/5634#discussion_r426106879) because the IDE always remove them by default, but if you could export the code style configuration that respects to the project's standard, it should avoid many code style violations in PRs 😅 WDYT @tristaZero
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] klboke closed pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
klboke closed pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kezhenxu94 commented on pull request #5760: Optimized aes encryption implementation
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632988254
The code style "keep indentation in blank lines" is a little bit unfriendly for new-comers (like me, at https://github.com/apache/shardingsphere/pull/5634#discussion_r426106879) because the IDE always remove them by default, but if you could export the code style configuration that respects to the project's standard, it should avoid many code style violations in PRs 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org