You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/06 14:42:28 UTC
[GitHub] [skywalking] arugal opened a new pull request #4454: Ignore no
upstream real address agent
arugal opened a new pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
https://github.com/apache/skywalking/issues/4396
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal merged pull request #4454: Ignore no upstream
real address agent
Posted by GitBox <gi...@apache.org>.
arugal merged pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389232951
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/entity/LanguageTrans.java
##########
@@ -33,6 +33,10 @@ public Language value(String language) {
return Language.PYTHON;
case "ruby":
return Language.RUBY;
+ case "go":
+ return Language.GO;
+ case "Lua":
Review comment:
I didn't notice this should be lower case. How about to use `toLowerCase` in the switch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389223596
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/ServiceInstanceInventoryCache.java
##########
@@ -119,4 +125,24 @@ public int getServiceInstanceId(int serviceId, int addressId) {
}
return serviceInstanceId;
}
+
+ public String getServiceInstanceLanguage(int serviceInstanceId) {
+ String language = languageCache.getIfPresent(serviceInstanceId);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389196271
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
##########
@@ -54,6 +54,9 @@
@Setter
@Getter
private UninstrumentedGatewaysConfig uninstrumentedGatewaysConfig;
+ @Setter
+ @Getter
+ private NoUpstreamRealAddressAgentConfig noUpstreamRealAddressAgentConfig;
Review comment:
We support list here, take a look at downsampling config. And you should put LUA as the default element.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389220981
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/parser/listener/service/ServiceInstanceMappingSpanListener.java
##########
@@ -79,6 +81,17 @@ public void parseEntry(SpanDecorator spanDecorator, SegmentCoreInfo segmentCoreI
if (!spanDecorator.getSpanLayer().equals(SpanLayer.MQ)) {
if (spanDecorator.getRefsCount() > 0) {
for (int i = 0; i < spanDecorator.getRefsCount(); i++) {
+ ReferenceDecorator referenceDecorator = spanDecorator.getRefs(i);
+ String parentLanguage = serviceInstanceInventoryCache.getServiceInstanceLanguage(referenceDecorator.getParentServiceInstanceId());
+ if (config.getNoUpstreamRealAddressAgents().contains(parentLanguage)) {
+ /*
+ * Some of the agent can not have the upstream real network address, such as https://github.com/apache/skywalking-nginx-lua.
+ */
+ if (log.isDebugEnabled()) {
Review comment:
We don't need the log too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4454: Ignore no upstream
real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#issuecomment-595807473
You seems breaking the e2e? Please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389195956
##########
File path: apm-dist/src/main/assembly/binary.xml
##########
@@ -51,6 +51,7 @@
<include>official_analysis.oal</include>
<include>gateways.yml</include>
<include>service-apdex-threshold.yml</include>
+ <include>no_upstream_real_address_agent.yml</include>
Review comment:
Don't use a new file. This is a very simple config, please add a field to tracr receiver module provider.
Only If the content is complex and usually changed, we need a separated file. This fix is not that case.
This config is nearly static, nearly no one should change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389222727
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/ServiceInstanceInventoryCache.java
##########
@@ -119,4 +125,24 @@ public int getServiceInstanceId(int serviceId, int addressId) {
}
return serviceInstanceId;
}
+
+ public String getServiceInstanceLanguage(int serviceInstanceId) {
+ String language = languageCache.getIfPresent(serviceInstanceId);
Review comment:
I think comparing to this implementation, I would say, adding a `no-@column` field in the `ServiceInstanceInventory` to cache the status should be better in performance and understanding.
And you should avoid check the language repeatedly if this instance hasn't language properties. Such as in the new implementation, you should separate the value from `null` and `Const#UNKNOWN`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4454: Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r388998664
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/NoUpstreamRealAddressAgentConfig.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.skywalking.oap.server.receiver.trace.provider;
+
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.apm.util.StringUtil;
+import org.apache.skywalking.oap.server.configuration.api.ConfigChangeWatcher;
+import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.library.util.ResourceUtils;
+import org.apache.skywalking.oap.server.receiver.trace.module.TraceModule;
+import org.yaml.snakeyaml.Yaml;
+
+import java.io.FileNotFoundException;
+import java.io.Reader;
+import java.util.Collections;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.stream.Collectors;
+
+@Slf4j
+public class NoUpstreamRealAddressAgentConfig extends ConfigChangeWatcher {
+
+ private final AtomicReference<String> settingsString;
+ private volatile Languages ignoreByLanguage = Languages.EMPTY;
+
+ public NoUpstreamRealAddressAgentConfig(TraceModuleProvider provider) {
+ super(TraceModule.NAME, provider, "noUpstreamRealAddressAgent");
+ this.settingsString = new AtomicReference<>(Const.EMPTY_STRING);
+ final Languages defaultLanguages = parseLanguageFromFile("no_upstream_real_address_agent.yml");
+ log.info("Default configured no upstream real address agent: {}", defaultLanguages);
+ onLanguageUpdated(defaultLanguages);
+ }
+
+ private void activeSetting(String config) {
+ if (log.isDebugEnabled()) {
+ log.debug("Updating using new static config: {}", config);
+ }
+ this.settingsString.set(config);
+ onLanguageUpdated(parseGatewayFromYml(config));
+ }
+
+ @Override
+ public void notify(ConfigChangeEvent value) {
+ if (EventType.DELETE.equals(value.getEventType())) {
+ activeSetting("");
+ } else {
+ activeSetting(value.getNewValue());
+ }
+ }
+
+ @Override
+ public String value() {
+ return settingsString.get();
+ }
+
+ private void onLanguageUpdated(final Languages languages) {
+ log.info("Updating no upstream real address agent with:{}", languages);
+ languages.languages = languages.getLanguages().stream().map(String::toLowerCase).collect(Collectors.toSet());
+ ignoreByLanguage = languages;
+ }
+
+ public boolean ignoreLanguage(final String language) {
+ if (StringUtil.isEmpty(language)) {
+ return false;
+ }
+ final boolean isIgnored = ignoreByLanguage.getLanguages().contains(language);
+ if (log.isDebugEnabled() && isIgnored) {
+ log.debug("Language [{}] is ignored", language);
+ }
+ return isIgnored;
+ }
+
+ private Languages parseLanguageFromFile(final String file) {
+ try {
+ final Reader reader = ResourceUtils.read(file);
+ return new Yaml().loadAs(reader, Languages.class);
+ } catch (FileNotFoundException e) {
+ log.error("Cannot load languages from: {}", file, e);
+ }
+ return Languages.EMPTY;
+ }
+
+ private Languages parseGatewayFromYml(final String ymlContent) {
Review comment:
Gateway?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389220969
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/parser/listener/endpoint/MultiScopesSpanListener.java
##########
@@ -306,7 +309,17 @@ public void build() {
exitSourceBuilder.setTimeBucket(minuteTimeBucket);
sourceReceiver.receive(exitSourceBuilder.toServiceRelation());
- sourceReceiver.receive(exitSourceBuilder.toServiceInstanceRelation());
+ String sourceLanguage = instanceInventoryCache.getServiceInstanceLanguage(exitSourceBuilder.getSourceServiceInstanceId());
+ if (config.getNoUpstreamRealAddressAgents().contains(sourceLanguage)) {
+ /*
+ * Some of the agent can not have the upstream real network address, such as https://github.com/apache/skywalking-nginx-lua.
+ */
+ if (log.isDebugEnabled()) {
Review comment:
I think we don't need log for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389220543
##########
File path: dist-material/application.yml
##########
@@ -180,6 +180,8 @@ receiver-trace:
bufferFileCleanWhenRestart: ${SW_RECEIVER_BUFFER_FILE_CLEAN_WHEN_RESTART:false}
sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The sample rate precision is 1/10000. 10000 means 100% sample in default.
slowDBAccessThreshold: ${SW_SLOW_DB_THRESHOLD:default:200,mongodb:100} # The slow database access thresholds. Unit ms.
+ noUpstreamRealAddressAgents: # The no upstream real address agents, service instance mapping and service instance client side relation are ignored.
Review comment:
I think we don't need to open this to the end user. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4454: Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r388996705
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/ServiceInstanceInventoryCache.java
##########
@@ -119,4 +127,22 @@ public int getServiceInstanceId(int serviceId, int addressId) {
}
return serviceInstanceId;
}
+
+ public String getServiceInstanceLanguage(int serviceInstanceId) {
+ String language = languageCache.getIfPresent(serviceInstanceId);
+ if (isNull(language)) {
+ ServiceInstanceInventory inventory = get(serviceInstanceId);
+ if (nonNull(inventory)) {
+ JsonObject properties = inventory.getProperties();
+ for (String key : properties.keySet()) {
+ if (key.equals(ServiceInstanceInventory.PropertyUtil.LANGUAGE)) {
+ language = properties.get(key).getAsString().toLowerCase();
+ languageCache.put(serviceInstanceId, language);
+ return language;
+ }
+ }
+ }
+ }
+ return Const.EMPTY_STRING;
+ }
Review comment:
Consider using "fast return", instead of so many nested blocks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389221459
##########
File path: dist-material/application.yml
##########
@@ -180,6 +180,8 @@ receiver-trace:
bufferFileCleanWhenRestart: ${SW_RECEIVER_BUFFER_FILE_CLEAN_WHEN_RESTART:false}
sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The sample rate precision is 1/10000. 10000 means 100% sample in default.
slowDBAccessThreshold: ${SW_SLOW_DB_THRESHOLD:default:200,mongodb:100} # The slow database access thresholds. Unit ms.
+ noUpstreamRealAddressAgents: # The no upstream real address agents, service instance mapping and service instance client side relation are ignored.
Review comment:
Agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389223586
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
##########
@@ -41,7 +44,13 @@
@Setter
@Getter
private int sampleRate = 10000;
-
+ /**
+ * Some of the agent can not have the upstream real network address, such as https://github.com/apache/skywalking-nginx-lua.
+ * service instance mapping and service instance client side relation are ignored.
+ */
+ @Setter
+ @Getter
+ private List<String> noUpstreamRealAddressAgents = Collections.emptyList();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389223590
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
##########
@@ -54,6 +54,9 @@
@Setter
@Getter
private UninstrumentedGatewaysConfig uninstrumentedGatewaysConfig;
+ @Setter
+ @Getter
+ private NoUpstreamRealAddressAgentConfig noUpstreamRealAddressAgentConfig;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389221235
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/ServiceInstanceInventoryCache.java
##########
@@ -119,4 +127,22 @@ public int getServiceInstanceId(int serviceId, int addressId) {
}
return serviceInstanceId;
}
+
+ public String getServiceInstanceLanguage(int serviceInstanceId) {
+ String language = languageCache.getIfPresent(serviceInstanceId);
+ if (isNull(language)) {
+ ServiceInstanceInventory inventory = get(serviceInstanceId);
+ if (nonNull(inventory)) {
+ JsonObject properties = inventory.getProperties();
+ for (String key : properties.keySet()) {
+ if (key.equals(ServiceInstanceInventory.PropertyUtil.LANGUAGE)) {
+ language = properties.get(key).getAsString().toLowerCase();
+ languageCache.put(serviceInstanceId, language);
+ return language;
+ }
+ }
+ }
+ }
+ return Const.EMPTY_STRING;
+ }
Review comment:
Done, thanks for your review :laughing:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389233486
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/entity/LanguageTrans.java
##########
@@ -33,6 +33,10 @@ public Language value(String language) {
return Language.PYTHON;
case "ruby":
return Language.RUBY;
+ case "go":
+ return Language.GO;
+ case "Lua":
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4454:
Ignore no upstream real address agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4454: Ignore no upstream real address agent
URL: https://github.com/apache/skywalking/pull/4454#discussion_r389220888
##########
File path: oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
##########
@@ -41,7 +44,13 @@
@Setter
@Getter
private int sampleRate = 10000;
-
+ /**
+ * Some of the agent can not have the upstream real network address, such as https://github.com/apache/skywalking-nginx-lua.
+ * service instance mapping and service instance client side relation are ignored.
+ */
+ @Setter
+ @Getter
+ private List<String> noUpstreamRealAddressAgents = Collections.emptyList();
Review comment:
This should be initialized to include LUA. As a native agent, we know, LUA agent can't support in this value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services