You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by Simone Tripodi <si...@apache.org> on 2012/08/07 11:18:30 UTC
Any23 Modularization
Hi Peter,
> I am looking in the short term to restructure the Maven modules inside
> of Any23 so that the different facets can be reused, tested and
> maintained easily, particularly with a view to using the RDF related
> Tika enhancements that the Any23 MIME Detector provides. I made these
> changes a few months ago in my GitHub fork [2], so feel free to review
> them closely to suggest enhancements before I actually start. I am not
> sure when I will next have time to clean up the patches. The first
> step that I want to take is to split out the test resources into a
> single module and switch from "src/test/resources/*" File based access
> in tests to using this.getClass().getResourceAsStream("*"). I have
> implemented those changes in my git repository but the patches may
> need cleaning up as I have not gone back to review them yet. After
> that is done, it will be relatively simple to split out both the
> packages and tests into separate modules.
You have my full support on this step, I would be more than glad to
provide feedbacks - feel free to ping me when/if needed!
I also think we could take advantage from this work to get rid of many
builders-of-factories and switching the Any23 runtime environment to
something more standard-ish, i.e. JSR-330
<http://www.jcp.org/en/jsr/detail?id=330>
Have a nice day, all the best!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
Re: Any23 Modularization
Posted by Simone Tripodi <si...@apache.org>.
> The purpose of service locators in my experience is to decouple
> services so that they are explicitly not required at compile time. It
> depends whether you want arbitrary sets of services, or just a single
> place to define specific singleton/global services as to whether you
> would find it useful to specify services in a compiled java file or in
> a configuration file. ServiceLoader is not designed to be a
> configuration framework to define specific services, but it is great
> if you want to use any and all services that are available.
>
sure, that is indeed the way we _already use_ the ServiceLoader to
dynamically load Any23 CLI plugins, but I was referring to the fact
that the ServiceLoader is not typesafe as you asserted, since wrong
bindings between service definition and implementations can be
detected at runtime only. There's no way ATM javac checks services
type defined in META-INF/services.
> From what I can tell, in Any23 we want to load up any and all services
> that are available at runtime and the user will specify which one they
> want to use with an identifier or MIME-Type, so ServiceLoader fits
> that purpose in my view.
+1 I like the idea
>
> In the api patch I tried to reduce the confusion, particularly
> removing the use of Class.getConstructor in WriterRegistry and
> replacing it with a factory. There are two FIXME notes in the patch
> where I would like to remove hardcoded factories and format
> identifiers.
>
good! I will try to have a look tomorrow, didn't find enough spare time today :(
best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
Re: Any23 Modularization
Posted by Peter Ansell <an...@gmail.com>.
On 10 August 2012 19:16, Simone Tripodi <si...@apache.org> wrote:
>> There is at least one statement in that code that I don't think is
>> true in my experience. The author of that JSR says that "Service
>> locators decouple even further but reduce compile time type safety". I
>> am not sure what service locators they have been using, but
>> java.util.ServiceLoader is definitely typesafe, especially if you use
>> it with a Factory interface instead of using reflection to instantiate
>> the object manually. In my experience using java.util.ServiceLoader on
>> my own projects and in my work with OWLAPI, I have found that you can
>> have a typesafe plugin system quite easily without relying on a
>> dependency injection system to do it for you.
>>
>
> they are not indeed the same kind of service locators, and the one you
> are referring is definitely NOT typesafe because in
> META-INF/services/com.acme.Interface definition you are free to
> specify a class which doesn't implement com.acme.Interface - and you
> can find that misconfiguration at *runtime* only.
>
> Modern DI framework allows specify typesafe services in a pure java
> config which is checked at *compile* time.
The purpose of service locators in my experience is to decouple
services so that they are explicitly not required at compile time. It
depends whether you want arbitrary sets of services, or just a single
place to define specific singleton/global services as to whether you
would find it useful to specify services in a compiled java file or in
a configuration file. ServiceLoader is not designed to be a
configuration framework to define specific services, but it is great
if you want to use any and all services that are available.
>From what I can tell, in Any23 we want to load up any and all services
that are available at runtime and the user will specify which one they
want to use with an identifier or MIME-Type, so ServiceLoader fits
that purpose in my view.
> FYI, ServiceLoader is already in use in Any23 to load plugins and
> META-INF/services files are generated at compile time via the metainf
> library developed by Kohsuke (the Jenkin's guy). Anyway, we've had a
> broken test anyway, due to misconfigurations in META-INF/services :)
>
>> However I don't mind if you want to put in JSR-330 annotations in the
>> apprpriate places. I am just wary of cases when a library forces you
>> to use dynamic dependency injection and either makes it very hard or
>> impossible to do it using a plain-old-java way. As long as the code
>> doesn't lock things down by doing things like creating private fields
>> with no accessors or mutators except for DI magic, I am fine with it.
>> Personally, I don't mind maintaining Factories as I am going to be
>> using them myself, since I don't generally use DI, and using Open
>> Source code I am free to create the factories if they don't exist.
>>
>
> I never mentioned adopting a specific framework that forces us on
> writing stuff according to its rule, just referenced to the JRS.
>
> Factories are still fine, but not how they are used in the current
> codebase - they often get me feel lost while reviewing before the
> release.
In the api patch I tried to reduce the confusion, particularly
removing the use of Class.getConstructor in WriterRegistry and
replacing it with a factory. There are two FIXME notes in the patch
where I would like to remove hardcoded factories and format
identifiers.
Cheers,
Peter
Re: Any23 Modularization
Posted by Simone Tripodi <si...@apache.org>.
> There is at least one statement in that code that I don't think is
> true in my experience. The author of that JSR says that "Service
> locators decouple even further but reduce compile time type safety". I
> am not sure what service locators they have been using, but
> java.util.ServiceLoader is definitely typesafe, especially if you use
> it with a Factory interface instead of using reflection to instantiate
> the object manually. In my experience using java.util.ServiceLoader on
> my own projects and in my work with OWLAPI, I have found that you can
> have a typesafe plugin system quite easily without relying on a
> dependency injection system to do it for you.
>
they are not indeed the same kind of service locators, and the one you
are referring is definitely NOT typesafe because in
META-INF/services/com.acme.Interface definition you are free to
specify a class which doesn't implement com.acme.Interface - and you
can find that misconfiguration at *runtime* only.
Modern DI framework allows specify typesafe services in a pure java
config which is checked at *compile* time.
FYI, ServiceLoader is already in use in Any23 to load plugins and
META-INF/services files are generated at compile time via the metainf
library developed by Kohsuke (the Jenkin's guy). Anyway, we've had a
broken test anyway, due to misconfigurations in META-INF/services :)
> However I don't mind if you want to put in JSR-330 annotations in the
> apprpriate places. I am just wary of cases when a library forces you
> to use dynamic dependency injection and either makes it very hard or
> impossible to do it using a plain-old-java way. As long as the code
> doesn't lock things down by doing things like creating private fields
> with no accessors or mutators except for DI magic, I am fine with it.
> Personally, I don't mind maintaining Factories as I am going to be
> using them myself, since I don't generally use DI, and using Open
> Source code I am free to create the factories if they don't exist.
>
I never mentioned adopting a specific framework that forces us on
writing stuff according to its rule, just referenced to the JRS.
Factories are still fine, but not how they are used in the current
codebase - they often get me feel lost while reviewing before the
release.
> Cheers,
>
> Peter
best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
Re: Any23 Modularization
Posted by Peter Ansell <an...@gmail.com>.
On 7 August 2012 19:18, Simone Tripodi <si...@apache.org> wrote:
> Hi Peter,
>
>> I am looking in the short term to restructure the Maven modules inside
>> of Any23 so that the different facets can be reused, tested and
>> maintained easily, particularly with a view to using the RDF related
>> Tika enhancements that the Any23 MIME Detector provides. I made these
>> changes a few months ago in my GitHub fork [2], so feel free to review
>> them closely to suggest enhancements before I actually start. I am not
>> sure when I will next have time to clean up the patches. The first
>> step that I want to take is to split out the test resources into a
>> single module and switch from "src/test/resources/*" File based access
>> in tests to using this.getClass().getResourceAsStream("*"). I have
>> implemented those changes in my git repository but the patches may
>> need cleaning up as I have not gone back to review them yet. After
>> that is done, it will be relatively simple to split out both the
>> packages and tests into separate modules.
>
> You have my full support on this step, I would be more than glad to
> provide feedbacks - feel free to ping me when/if needed!
>
> I also think we could take advantage from this work to get rid of many
> builders-of-factories and switching the Any23 runtime environment to
> something more standard-ish, i.e. JSR-330
> <http://www.jcp.org/en/jsr/detail?id=330>
I have never seen or used JSR-330 before so I can't comment on whether
it is useful to us or not, although searching for it on the web seems
to show that most of the dependency injection libraries have support
for it, ie, Spring and Guice among others.
There is at least one statement in that code that I don't think is
true in my experience. The author of that JSR says that "Service
locators decouple even further but reduce compile time type safety". I
am not sure what service locators they have been using, but
java.util.ServiceLoader is definitely typesafe, especially if you use
it with a Factory interface instead of using reflection to instantiate
the object manually. In my experience using java.util.ServiceLoader on
my own projects and in my work with OWLAPI, I have found that you can
have a typesafe plugin system quite easily without relying on a
dependency injection system to do it for you.
However I don't mind if you want to put in JSR-330 annotations in the
apprpriate places. I am just wary of cases when a library forces you
to use dynamic dependency injection and either makes it very hard or
impossible to do it using a plain-old-java way. As long as the code
doesn't lock things down by doing things like creating private fields
with no accessors or mutators except for DI magic, I am fine with it.
Personally, I don't mind maintaining Factories as I am going to be
using them myself, since I don't generally use DI, and using Open
Source code I am free to create the factories if they don't exist.
Cheers,
Peter
Re: Any23 Modularization
Posted by Michele Mostarda <mi...@gmail.com>.
On 10 August 2012 06:27, Peter Ansell <an...@gmail.com> wrote:
> Hi all,
>
> I checked over the test-resource-jar patch again this morning and it
> still looked right, and all of the tests still pass, so I committed it
> to subversion.
>
+1
>
> I have since ported a patch across from my previous patches to create
> an apache-any23-api.jar file that contains the basic information
> needed to split up the rest of the core module. [2]
>
+1
>
> I also discovered that the URL at [1] was comparing against the
> apache-git:trunk (at GitHub, which is not updated that regularly,
> ~once a day it seems). Using ansell:trunk in the GitHub compare URL
> compares against whatever I have last downloaded from git.apache.org.
>
> If someone wants to review it and comment here or on ANY23-114 in the
> next 48 hours I will commit it to subversion with any necessary
> changes after the weekend. (Assuming Jira is working, which it doesn't
> seem to be about 50 percent of the time right now). I have been
> working personally using this api module (and the test-resource-jar
> module) for the past 3 months (api module first committed on May 10),
> so I doubt there is anything majorly wrong with the patch, but any
> reviews are always helpful.
>
Jira is down now, will try later in the afternoon :(
>
> Cheers,
>
> Peter
>
Cheers.
Mic
>
> [2]
> https://github.com/ansell/any23/compare/ansell:trunk...ansell:api-module
>
> On 9 August 2012 12:47, Peter Ansell <an...@gmail.com> wrote:
> > Hi,
> >
> > I have a patch on GitHub [1] available to move the test resources out
> > into their own module and modify the tests to work by copying the
> > resources out to temporary files that are all cleaned up by JUnit
> > after each test.
> >
> > The Apache Jira does not appear to be available right now, but this
> > corresponds to ANY23-103 that I filed in June.
> >
> > Could someone review that patch for me as it is quite large and I may
> > have added something that was not necessary.
> >
> > This patch is the precursor to the modularisation process, as without
> > it the tests cannot be moved out of the core module.
> >
> > Thanks,
> >
> > Peter
> >
> > [1] https://github.com/ansell/any23/compare/trunk...test-resource-jar
> >
> > On 7 August 2012 21:16, Lewis John Mcgibbney <le...@gmail.com>
> wrote:
> >> Hi Simo,
> >>
> >> I also provide my full backing for this. I think Peter's suggestion
> >> here was an excellent injection and I would back the restructuring
> >> effort entirely as well.
> >> Lewis
> >>
> >> On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi
> >> <si...@apache.org> wrote:
> >>> Hi Peter,
> >>>
> >>>> I am looking in the short term to restructure the Maven modules inside
> >>>> of Any23 so that the different facets can be reused, tested and
> >>>> maintained easily, particularly with a view to using the RDF related
> >>>> Tika enhancements that the Any23 MIME Detector provides. I made these
> >>>> changes a few months ago in my GitHub fork [2], so feel free to review
> >>>> them closely to suggest enhancements before I actually start. I am not
> >>>> sure when I will next have time to clean up the patches. The first
> >>>> step that I want to take is to split out the test resources into a
> >>>> single module and switch from "src/test/resources/*" File based access
> >>>> in tests to using this.getClass().getResourceAsStream("*"). I have
> >>>> implemented those changes in my git repository but the patches may
> >>>> need cleaning up as I have not gone back to review them yet. After
> >>>> that is done, it will be relatively simple to split out both the
> >>>> packages and tests into separate modules.
> >>>
> >>> You have my full support on this step, I would be more than glad to
> >>> provide feedbacks - feel free to ping me when/if needed!
> >>>
> >>> I also think we could take advantage from this work to get rid of many
> >>> builders-of-factories and switching the Any23 runtime environment to
> >>> something more standard-ish, i.e. JSR-330
> >>> <http://www.jcp.org/en/jsr/detail?id=330>
> >>>
> >>> Have a nice day, all the best!
> >>> -Simo
> >>>
> >>> http://people.apache.org/~simonetripodi/
> >>> http://simonetripodi.livejournal.com/
> >>> http://twitter.com/simonetripodi
> >>> http://www.99soft.org/
> >>
> >>
> >>
> >> --
> >> Lewis
>
--
Michele Mostarda
Senior Software Engineer
skype: michele.mostarda
twitter: micmos
mail: me@michelemostarda.com
site : http://www.michelemostarda.com
Re: Any23 Modularization
Posted by Peter Ansell <an...@gmail.com>.
Hi Simone,
I was on IRC and watching the twitter feed, so I knew they were aware
of the problem. I received one email from committers@ about this
issue, so I am not sure whether I am automatically subscribed to it.
The committers@ email came after the email I sent from memory though.
Hopefully now that Jira is on a dedicated machine it should be more stable.
Peter
On 10 August 2012 19:19, Simone Tripodi <si...@apache.org> wrote:
> Hi Peter,
>
>> Assuming Jira is working, which it doesn't
>> seem to be about 50 percent of the time right now
>
> I suggest you subscribing to committers@ where INFRA is keeping
> committers updated to related problems. They have indeed an Issue with
> JIRA.
>
> HTH,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
Re: Any23 Modularization
Posted by Simone Tripodi <si...@apache.org>.
Hi Peter,
> Assuming Jira is working, which it doesn't
> seem to be about 50 percent of the time right now
I suggest you subscribing to committers@ where INFRA is keeping
committers updated to related problems. They have indeed an Issue with
JIRA.
HTH,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
Re: Any23 Modularization
Posted by Peter Ansell <an...@gmail.com>.
Hi all,
I checked over the test-resource-jar patch again this morning and it
still looked right, and all of the tests still pass, so I committed it
to subversion.
I have since ported a patch across from my previous patches to create
an apache-any23-api.jar file that contains the basic information
needed to split up the rest of the core module. [2]
I also discovered that the URL at [1] was comparing against the
apache-git:trunk (at GitHub, which is not updated that regularly,
~once a day it seems). Using ansell:trunk in the GitHub compare URL
compares against whatever I have last downloaded from git.apache.org.
If someone wants to review it and comment here or on ANY23-114 in the
next 48 hours I will commit it to subversion with any necessary
changes after the weekend. (Assuming Jira is working, which it doesn't
seem to be about 50 percent of the time right now). I have been
working personally using this api module (and the test-resource-jar
module) for the past 3 months (api module first committed on May 10),
so I doubt there is anything majorly wrong with the patch, but any
reviews are always helpful.
Cheers,
Peter
[2] https://github.com/ansell/any23/compare/ansell:trunk...ansell:api-module
On 9 August 2012 12:47, Peter Ansell <an...@gmail.com> wrote:
> Hi,
>
> I have a patch on GitHub [1] available to move the test resources out
> into their own module and modify the tests to work by copying the
> resources out to temporary files that are all cleaned up by JUnit
> after each test.
>
> The Apache Jira does not appear to be available right now, but this
> corresponds to ANY23-103 that I filed in June.
>
> Could someone review that patch for me as it is quite large and I may
> have added something that was not necessary.
>
> This patch is the precursor to the modularisation process, as without
> it the tests cannot be moved out of the core module.
>
> Thanks,
>
> Peter
>
> [1] https://github.com/ansell/any23/compare/trunk...test-resource-jar
>
> On 7 August 2012 21:16, Lewis John Mcgibbney <le...@gmail.com> wrote:
>> Hi Simo,
>>
>> I also provide my full backing for this. I think Peter's suggestion
>> here was an excellent injection and I would back the restructuring
>> effort entirely as well.
>> Lewis
>>
>> On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi
>> <si...@apache.org> wrote:
>>> Hi Peter,
>>>
>>>> I am looking in the short term to restructure the Maven modules inside
>>>> of Any23 so that the different facets can be reused, tested and
>>>> maintained easily, particularly with a view to using the RDF related
>>>> Tika enhancements that the Any23 MIME Detector provides. I made these
>>>> changes a few months ago in my GitHub fork [2], so feel free to review
>>>> them closely to suggest enhancements before I actually start. I am not
>>>> sure when I will next have time to clean up the patches. The first
>>>> step that I want to take is to split out the test resources into a
>>>> single module and switch from "src/test/resources/*" File based access
>>>> in tests to using this.getClass().getResourceAsStream("*"). I have
>>>> implemented those changes in my git repository but the patches may
>>>> need cleaning up as I have not gone back to review them yet. After
>>>> that is done, it will be relatively simple to split out both the
>>>> packages and tests into separate modules.
>>>
>>> You have my full support on this step, I would be more than glad to
>>> provide feedbacks - feel free to ping me when/if needed!
>>>
>>> I also think we could take advantage from this work to get rid of many
>>> builders-of-factories and switching the Any23 runtime environment to
>>> something more standard-ish, i.e. JSR-330
>>> <http://www.jcp.org/en/jsr/detail?id=330>
>>>
>>> Have a nice day, all the best!
>>> -Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>
>>
>>
>> --
>> Lewis
Re: Any23 Modularization
Posted by Michele Mostarda <mi...@gmail.com>.
On 9 August 2012 04:47, Peter Ansell <an...@gmail.com> wrote:
> Hi,
>
> I have a patch on GitHub [1] available to move the test resources out
> into their own module and modify the tests to work by copying the
> resources out to temporary files that are all cleaned up by JUnit
> after each test.
>
> The Apache Jira does not appear to be available right now, but this
> corresponds to ANY23-103 that I filed in June.
>
> Could someone review that patch for me as it is quite large and I may
> have added something that was not necessary.
>
Hi Peter, I quickly reviewed the patch content (didn't try it) and it
seemed ok to me.
The tests really required a strong refactoring as you did.
Good job!
> This patch is the precursor to the modularisation process, as without
> it the tests cannot be moved out of the core module.
>
> Thanks,
>
> Peter
>
The best.
Mic
>
> [1] https://github.com/ansell/any23/compare/trunk...test-resource-jar
>
> On 7 August 2012 21:16, Lewis John Mcgibbney <le...@gmail.com>
> wrote:
> > Hi Simo,
> >
> > I also provide my full backing for this. I think Peter's suggestion
> > here was an excellent injection and I would back the restructuring
> > effort entirely as well.
> > Lewis
> >
> > On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi
> > <si...@apache.org> wrote:
> >> Hi Peter,
> >>
> >>> I am looking in the short term to restructure the Maven modules inside
> >>> of Any23 so that the different facets can be reused, tested and
> >>> maintained easily, particularly with a view to using the RDF related
> >>> Tika enhancements that the Any23 MIME Detector provides. I made these
> >>> changes a few months ago in my GitHub fork [2], so feel free to review
> >>> them closely to suggest enhancements before I actually start. I am not
> >>> sure when I will next have time to clean up the patches. The first
> >>> step that I want to take is to split out the test resources into a
> >>> single module and switch from "src/test/resources/*" File based access
> >>> in tests to using this.getClass().getResourceAsStream("*"). I have
> >>> implemented those changes in my git repository but the patches may
> >>> need cleaning up as I have not gone back to review them yet. After
> >>> that is done, it will be relatively simple to split out both the
> >>> packages and tests into separate modules.
> >>
> >> You have my full support on this step, I would be more than glad to
> >> provide feedbacks - feel free to ping me when/if needed!
> >>
> >> I also think we could take advantage from this work to get rid of many
> >> builders-of-factories and switching the Any23 runtime environment to
> >> something more standard-ish, i.e. JSR-330
> >> <http://www.jcp.org/en/jsr/detail?id=330>
> >>
> >> Have a nice day, all the best!
> >> -Simo
> >>
> >> http://people.apache.org/~simonetripodi/
> >> http://simonetripodi.livejournal.com/
> >> http://twitter.com/simonetripodi
> >> http://www.99soft.org/
> >
> >
> >
> > --
> > Lewis
>
--
Michele Mostarda
Senior Software Engineer
skype: michele.mostarda
twitter: micmos
mail: me@michelemostarda.com
site : http://www.michelemostarda.com
Re: Any23 Modularization
Posted by Peter Ansell <an...@gmail.com>.
Hi,
I have a patch on GitHub [1] available to move the test resources out
into their own module and modify the tests to work by copying the
resources out to temporary files that are all cleaned up by JUnit
after each test.
The Apache Jira does not appear to be available right now, but this
corresponds to ANY23-103 that I filed in June.
Could someone review that patch for me as it is quite large and I may
have added something that was not necessary.
This patch is the precursor to the modularisation process, as without
it the tests cannot be moved out of the core module.
Thanks,
Peter
[1] https://github.com/ansell/any23/compare/trunk...test-resource-jar
On 7 August 2012 21:16, Lewis John Mcgibbney <le...@gmail.com> wrote:
> Hi Simo,
>
> I also provide my full backing for this. I think Peter's suggestion
> here was an excellent injection and I would back the restructuring
> effort entirely as well.
> Lewis
>
> On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi
> <si...@apache.org> wrote:
>> Hi Peter,
>>
>>> I am looking in the short term to restructure the Maven modules inside
>>> of Any23 so that the different facets can be reused, tested and
>>> maintained easily, particularly with a view to using the RDF related
>>> Tika enhancements that the Any23 MIME Detector provides. I made these
>>> changes a few months ago in my GitHub fork [2], so feel free to review
>>> them closely to suggest enhancements before I actually start. I am not
>>> sure when I will next have time to clean up the patches. The first
>>> step that I want to take is to split out the test resources into a
>>> single module and switch from "src/test/resources/*" File based access
>>> in tests to using this.getClass().getResourceAsStream("*"). I have
>>> implemented those changes in my git repository but the patches may
>>> need cleaning up as I have not gone back to review them yet. After
>>> that is done, it will be relatively simple to split out both the
>>> packages and tests into separate modules.
>>
>> You have my full support on this step, I would be more than glad to
>> provide feedbacks - feel free to ping me when/if needed!
>>
>> I also think we could take advantage from this work to get rid of many
>> builders-of-factories and switching the Any23 runtime environment to
>> something more standard-ish, i.e. JSR-330
>> <http://www.jcp.org/en/jsr/detail?id=330>
>>
>> Have a nice day, all the best!
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>
>
>
> --
> Lewis
Re: Any23 Modularization
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi Simo,
I also provide my full backing for this. I think Peter's suggestion
here was an excellent injection and I would back the restructuring
effort entirely as well.
Lewis
On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi
<si...@apache.org> wrote:
> Hi Peter,
>
>> I am looking in the short term to restructure the Maven modules inside
>> of Any23 so that the different facets can be reused, tested and
>> maintained easily, particularly with a view to using the RDF related
>> Tika enhancements that the Any23 MIME Detector provides. I made these
>> changes a few months ago in my GitHub fork [2], so feel free to review
>> them closely to suggest enhancements before I actually start. I am not
>> sure when I will next have time to clean up the patches. The first
>> step that I want to take is to split out the test resources into a
>> single module and switch from "src/test/resources/*" File based access
>> in tests to using this.getClass().getResourceAsStream("*"). I have
>> implemented those changes in my git repository but the patches may
>> need cleaning up as I have not gone back to review them yet. After
>> that is done, it will be relatively simple to split out both the
>> packages and tests into separate modules.
>
> You have my full support on this step, I would be more than glad to
> provide feedbacks - feel free to ping me when/if needed!
>
> I also think we could take advantage from this work to get rid of many
> builders-of-factories and switching the Any23 runtime environment to
> something more standard-ish, i.e. JSR-330
> <http://www.jcp.org/en/jsr/detail?id=330>
>
> Have a nice day, all the best!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
--
Lewis