You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/19 02:23:07 UTC
[GitHub] [bookkeeper] zymap commented on a diff in pull request #3450: Fix wrong stats name
zymap commented on code in PR #3450:
URL: https://github.com/apache/bookkeeper/pull/3450#discussion_r949742882
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -216,7 +217,7 @@ public JournalStats(StatsLogger statsLogger, final long maxJournalMemoryBytes,
journalQueueSize = statsLogger.getCounter(BookKeeperServerStats.JOURNAL_QUEUE_SIZE);
forceWriteQueueSize = statsLogger.getCounter(BookKeeperServerStats.JOURNAL_FORCE_WRITE_QUEUE_SIZE);
journalCbQueueSize = statsLogger.getCounter(BookKeeperServerStats.JOURNAL_CB_QUEUE_SIZE);
- cbThreadPoolQueueSize = statsLogger.getCounter(BookKeeperServerStats.CB_THREAD_POOL_QUEUE_SIZE);
+ cbThreadPoolQueueSize = statsLogger.getCounter(CB_THREAD_POOL_QUEUE_SIZE);
Review Comment:
```suggestion
cbThreadPoolQueueSize = statsLogger.getCounter(BookKeeperServerStats.CB_THREAD_POOL_QUEUE_SIZE);
```
Keep the style with others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org