[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

["Qifan Chen (Code Review)" <ge...@cloudera.org>]

Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 )

Change subject: IMPALA-9294: Support DATE for min-max runtime filter
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

The addition looks good to me. Thanks!

http://gerrit.cloudera.org:8080/#/c/16103/3/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test
File testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test:

http://gerrit.cloudera.org:8080/#/c/16103/3/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@168
PS3, Line 168: functional_kudu.date_tbl a
             :     join [BROADCAST] functional_kudu.date_tbl b
> Ok, I will add new 3-way join test case if I need to submit new patch.
Looks good to me. One question on the broadcast hint used in the query: just wonder if a shuffle parallel plan works too. In such a plan, the min/max from different impalads need to be consolidated.



-- 
To view, visit http://gerrit.cloudera.org:8080/16103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2f6e2dc6949735d5f0fcf317361cc2969a5e82c
Gerrit-Change-Number: 16103
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2020 20:48:32 +0000
Gerrit-HasComments: Yes