You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by riknoll <gi...@git.apache.org> on 2015/09/19 00:13:29 UTC
[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/354
Add Keyword Index back to the table of contents
Adds a translated keyword index page for each version of the docs that lists all the pages for that language/version. Page titles are scraped using toc.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/riknoll/cordova-docs cordova-website-page-index
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit cb2b3c5a810afd7249fd547321c4153938927c6c
Author: riknoll <ri...@microsoft.com>
Date: 2015-09-18T19:15:34Z
Added page indices to the docs
commit 39c411f9132c7b5697f483df4f626baacb4f1fd8
Author: riknoll <ri...@microsoft.com>
Date: 2015-09-18T20:49:47Z
Added the keyword index back into the toc
commit e2b58c7264cddd0ca8dcf5fd42f319285da57342
Author: riknoll <ri...@microsoft.com>
Date: 2015-09-18T21:46:58Z
Copied TOC entries for page_index.md to the title for translation purposes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/354#issuecomment-141606098
Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/354#issuecomment-141606085
Yep, LGTM. There is no user input, so there shouldn't be any security issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/354#issuecomment-141582319
and the docs_index.html _include as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/354#issuecomment-141581959
@dblotsky can you review docs-keyword-index.js to make sure there aren't any security issues with how the page is taken from the Jekyll generated JSON and built?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Add Keyword Index back to the table of ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-docs/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org