You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "magicgoody (via GitHub)" <gi...@apache.org> on 2023/08/11 10:09:53 UTC
[GitHub] [beam] magicgoody opened a new pull request, #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
magicgoody opened a new pull request, #27965:
URL: https://github.com/apache/beam/pull/27965
PR migrates Jenkins Jobs to Github Actions Workflow ".github\workflows\beam_PreCommit_SQL_Java17.yml":
https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_SQL_Java17_Commit/
https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_SQL_Java17_Cron/
https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_SQL_Java17_Phrase/
The code has been tested on Self-hosted GKE runners ubuntu 20.04, and on Self-hosted local ubuntu 20.04 machine.
The tests was made by creating pull requests with changes in trigger paths, by adding a comment to the PR, by creating a push.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1293874933
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java 17
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '17'
+ - name: Set up Java 8
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '8'
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
+ - name: Install Flutter
Review Comment:
Checked without Flutter, test works fine. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1293469810
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java 17
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '17'
+ - name: Set up Java 8
Review Comment:
Could we add a comment explaining the double Java installation? Even if we don't fully understand it its ok, just something along the lines of:
```
Setup both Java 17 and Java 8 so that both are available in our environment.
Setup Java 8 second so that JAVA_HOME points to Java 8
```
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java 17
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '17'
+ - name: Set up Java 8
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '8'
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: '3.8'
+ - name: Install Flutter
Review Comment:
Why do we need flutter? Is this actually used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27965:
URL: https://github.com/apache/beam/pull/27965#issuecomment-1677329765
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1291215160
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java 17
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '17'
+ - name: Set up Java 8
Review Comment:
Can we use 'setup-self-hosted-action' here? For Java 8 and Python 3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1291236675
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
Review Comment:
I'm not sure about the answer, but I'm curious if it's possible to use the value of the matrix element here?
github.event.comment.body == matrix.job_phrase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1291212329
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
Review Comment:
Is it necessary to specify the Java version at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] volatilemolotov commented on pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on PR #27965:
URL: https://github.com/apache/beam/pull/27965#issuecomment-1677327961
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1293118380
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
Review Comment:
Your job name is beam_PreCommit_SQL_Java**17**
Is it necessary to include the Java version in the job's name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27965:
URL: https://github.com/apache/beam/pull/27965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] volatilemolotov commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1293274465
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
Review Comment:
the `if` part cannot access `matrix` elements unfortunately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1293874054
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java 17
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '17'
+ - name: Set up Java 8
Review Comment:
Comment added describing installation of java versions, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1293462312
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
Review Comment:
Job name in jenkins is "beam_PreCommit_SQL_Java17"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1291397943
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java 17
+ uses: actions/setup-java@v3.11.0
+ with:
+ distribution: 'temurin'
+ java-version: '17'
+ - name: Set up Java 8
Review Comment:
I think so, however I would leave things as they are for now. I only use the two packages that are listed. I see that the "setup-self-hosted-action" is still changing, and if additional packages are added in this action, the test should be re-checked to avoid installing additional packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1291386237
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
Review Comment:
This is the job name, could you please clarify your question?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #27965: Github Workflow Replacement for Jenkins Job, beam_PreCommit_SQL_Java17 (Cron, Commit, Phrase)
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #27965:
URL: https://github.com/apache/beam/pull/27965#discussion_r1291405613
##########
.github/workflows/beam_PreCommit_SQL_Java17.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PreCommit SQL Java17
+
+on:
+ push:
+ tags: ['v*']
+ branches: ['master', 'release-*']
+ paths: ['sdks/java/extensions/sql/**','.github/workflows/beam_PreCommit_SQL_Java17.yml']
+ pull_request_target:
+ branches: ['master', 'release-*']
+ paths: [sdks/java/extensions/sql/**]
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+jobs:
+ beam_PreCommit_SQL_Java17:
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ strategy:
+ matrix:
+ job_name: ["beam_PreCommit_SQL_Java17"]
+ job_phrase: ["Run SQL_Java17 PreCommit"]
+ timeout-minutes: 120
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'pull_request_target' ||
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run SQL_Java17 PreCommit'
Review Comment:
I think yes, I followed the template workflow style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org