You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Dolgov (JIRA)" <ji...@apache.org> on 2006/12/04 17:33:21 UTC
[jira] Created: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
[classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
-------------------------------------------------------------------------------------------
Key: HARMONY-2445
URL: http://issues.apache.org/jira/browse/HARMONY-2445
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Pavel Dolgov
Priority: Minor
Test case:
----------------
import java.awt.DefaultKeyboardFocusManager;
import junit.framework.TestCase;
public class TheTest extends TestCase {
public static void main(String args[]) {
junit.textui.TestRunner.run(TheTest.class);
}
public void testcase1() {
DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
try {
System.out.println(dkm.dispatchEvent(null));
fail("NPE expected");
} catch (NullPointerException e) {
} catch (Exception e) {
fail(e.getMessage());
}
}
}
RI output:
-------------
.
Time: 1,983
OK (1 test)
harmony output:
--------------
.false
F
Time: 0.511
There was 1 failure:
1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
at TheTest.testcase1(TheTest.java:15)
at java.lang.reflect.VMReflection.invokeMethod(Native Method)
at TheTest.main(TheTest.java:8)
FAILURES!!!
Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466526 ]
Alexei Zakharov commented on HARMONY-2445:
------------------------------------------
I tend to disagree here. IMHO it is ok to throw NPE when one of parameters is null. I suppose we should follow RI and create a patch for this JIRA.
> [classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-2445
> URL: https://issues.apache.org/jira/browse/HARMONY-2445
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pavel Dolgov
> Priority: Minor
>
> Test case:
> ----------------
> import java.awt.DefaultKeyboardFocusManager;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> public static void main(String args[]) {
> junit.textui.TestRunner.run(TheTest.class);
> }
> public void testcase1() {
> DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
> try {
> System.out.println(dkm.dispatchEvent(null));
> fail("NPE expected");
> } catch (NullPointerException e) {
> } catch (Exception e) {
> fail(e.getMessage());
> }
> }
> }
> RI output:
> -------------
> .
> Time: 1,983
> OK (1 test)
> harmony output:
> --------------
> .false
> F
> Time: 0.511
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
> at TheTest.testcase1(TheTest.java:15)
> at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2445?page=comments#action_12458397 ]
Andrey Pavlenko commented on HARMONY-2445:
------------------------------------------
I think the behavior of harmony is reasonable here. According to the specification this method should dispatch all events of type FocusEvent , WindowEvent and KeyEvent. All other events could be ignored, in this case this method returns false and the AWT event dispatcher should dispatch the event itself.
> [classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-2445
> URL: http://issues.apache.org/jira/browse/HARMONY-2445
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pavel Dolgov
> Priority: Minor
>
> Test case:
> ----------------
> import java.awt.DefaultKeyboardFocusManager;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> public static void main(String args[]) {
> junit.textui.TestRunner.run(TheTest.class);
> }
> public void testcase1() {
> DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
> try {
> System.out.println(dkm.dispatchEvent(null));
> fail("NPE expected");
> } catch (NullPointerException e) {
> } catch (Exception e) {
> fail(e.getMessage());
> }
> }
> }
> RI output:
> -------------
> .
> Time: 1,983
> OK (1 test)
> harmony output:
> --------------
> .false
> F
> Time: 0.511
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
> at TheTest.testcase1(TheTest.java:15)
> at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467024 ]
Andrey Pavlenko commented on HARMONY-2445:
------------------------------------------
Alexei, the patches are applied as expected, you can close the issue. Thanks.
> [classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-2445
> URL: https://issues.apache.org/jira/browse/HARMONY-2445
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pavel Dolgov
> Assigned To: Alexei Zakharov
> Priority: Minor
> Attachments: HARMONY-2445-DefaultKeyboardFocusManager.patch, HARMONY-2445-DefaultKeyboardFocusManagerTest.patch
>
>
> Test case:
> ----------------
> import java.awt.DefaultKeyboardFocusManager;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> public static void main(String args[]) {
> junit.textui.TestRunner.run(TheTest.class);
> }
> public void testcase1() {
> DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
> try {
> System.out.println(dkm.dispatchEvent(null));
> fail("NPE expected");
> } catch (NullPointerException e) {
> } catch (Exception e) {
> fail(e.getMessage());
> }
> }
> }
> RI output:
> -------------
> .
> Time: 1,983
> OK (1 test)
> harmony output:
> --------------
> .false
> F
> Time: 0.511
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
> at TheTest.testcase1(TheTest.java:15)
> at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Pavlenko updated HARMONY-2445:
-------------------------------------
Attachment: HARMONY-2445-DefaultKeyboardFocusManagerTest.patch
HARMONY-2445-DefaultKeyboardFocusManager.patch
Ok, I've attached the patches. Please try it.
> [classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-2445
> URL: https://issues.apache.org/jira/browse/HARMONY-2445
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pavel Dolgov
> Priority: Minor
> Attachments: HARMONY-2445-DefaultKeyboardFocusManager.patch, HARMONY-2445-DefaultKeyboardFocusManagerTest.patch
>
>
> Test case:
> ----------------
> import java.awt.DefaultKeyboardFocusManager;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> public static void main(String args[]) {
> junit.textui.TestRunner.run(TheTest.class);
> }
> public void testcase1() {
> DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
> try {
> System.out.println(dkm.dispatchEvent(null));
> fail("NPE expected");
> } catch (NullPointerException e) {
> } catch (Exception e) {
> fail(e.getMessage());
> }
> }
> }
> RI output:
> -------------
> .
> Time: 1,983
> OK (1 test)
> harmony output:
> --------------
> .false
> F
> Time: 0.511
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
> at TheTest.testcase1(TheTest.java:15)
> at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-2445.
--------------------------------------
Resolution: Fixed
Assignee: Alexei Zakharov
Thanks Andrey. Patches were committed at the revision r499372. Please verify.
> [classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-2445
> URL: https://issues.apache.org/jira/browse/HARMONY-2445
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pavel Dolgov
> Assigned To: Alexei Zakharov
> Priority: Minor
> Attachments: HARMONY-2445-DefaultKeyboardFocusManager.patch, HARMONY-2445-DefaultKeyboardFocusManagerTest.patch
>
>
> Test case:
> ----------------
> import java.awt.DefaultKeyboardFocusManager;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> public static void main(String args[]) {
> junit.textui.TestRunner.run(TheTest.class);
> }
> public void testcase1() {
> DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
> try {
> System.out.println(dkm.dispatchEvent(null));
> fail("NPE expected");
> } catch (NullPointerException e) {
> } catch (Exception e) {
> fail(e.getMessage());
> }
> }
> }
> RI output:
> -------------
> .
> Time: 1,983
> OK (1 test)
> harmony output:
> --------------
> .false
> F
> Time: 0.511
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
> at TheTest.testcase1(TheTest.java:15)
> at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-2445) [classlib][awt]
java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov closed HARMONY-2445.
------------------------------------
verified by the patches' author
> [classlib][awt] java.awt.DefaultKeyboardFocusManager.dispatchEvent(null) does not throw NPE
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-2445
> URL: https://issues.apache.org/jira/browse/HARMONY-2445
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pavel Dolgov
> Assigned To: Alexei Zakharov
> Priority: Minor
> Attachments: HARMONY-2445-DefaultKeyboardFocusManager.patch, HARMONY-2445-DefaultKeyboardFocusManagerTest.patch
>
>
> Test case:
> ----------------
> import java.awt.DefaultKeyboardFocusManager;
> import junit.framework.TestCase;
> public class TheTest extends TestCase {
> public static void main(String args[]) {
> junit.textui.TestRunner.run(TheTest.class);
> }
> public void testcase1() {
> DefaultKeyboardFocusManager dkm = new DefaultKeyboardFocusManager();
> try {
> System.out.println(dkm.dispatchEvent(null));
> fail("NPE expected");
> } catch (NullPointerException e) {
> } catch (Exception e) {
> fail(e.getMessage());
> }
> }
> }
> RI output:
> -------------
> .
> Time: 1,983
> OK (1 test)
> harmony output:
> --------------
> .false
> F
> Time: 0.511
> There was 1 failure:
> 1) testcase1(TheTest)junit.framework.AssertionFailedError: NPE expected
> at TheTest.testcase1(TheTest.java:15)
> at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> at TheTest.main(TheTest.java:8)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.