You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/27 21:27:41 UTC
[GitHub] graceguo-supercat commented on a change in pull request #4760: URL
shortner for dashboards
graceguo-supercat commented on a change in pull request #4760: URL shortner for dashboards
URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r184810144
##########
File path: superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##########
@@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
}
}
- addHistory({ isReplace = false, title }) {
Review comment:
if you removed this function, when user playing with chart controls, and they refresh their page (for any reason, without saving slice), will they lost the current query state? not all the query parameters are saved in slice yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services