You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2023/06/19 00:24:00 UTC

[jira] [Commented] (CALCITE-5786) QuidemTest and DiffRepository have incremental build issues

    [ https://issues.apache.org/jira/browse/CALCITE-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733971#comment-17733971 ] 

Julian Hyde commented on CALCITE-5786:
--------------------------------------

I updated the summary to describe the problem, not the fix. Can you update your commit message to match? Feel free to force-push to the PR's branch.

> QuidemTest and DiffRepository have incremental build issues
> -----------------------------------------------------------
>
>                 Key: CALCITE-5786
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5786
>             Project: Calcite
>          Issue Type: Improvement
>          Components: build, tests
>            Reporter: Akshay Dayal
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: Screenshot 2023-06-17 at 1.01.29 AM.png, Screenshot 2023-06-17 at 6.42.57 PM.png, Screenshot 2023-06-17 at 6.43.20 PM.png
>
>
> QuidemTest and DiffRepository have incremental build issues. The reason is that they write output to {{build/resources/test}}.
> The {{test}} tasks treat {{build/resources/test}} as an input, so if there are changes made to the directory the {{test}} tasks are considered no longer UP-TO-DATE.
> Currently {{QuidemTest}} and {{DiffRepository}}, which are used by tests, write to this directory. DiffRepository writes test results to be compared with expected results. {{QuidemTest}} creates some sql files which are used during testing. This causes issues with incremental build support for the {{test}} tasks. I'm attaching screenshots from a build scan to show this.
> Neither of these need to be written to the {{build/resources/test}} directory, they can be put somewhere else in the {{build}} directory and therefore not cause issues with incremental build support.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)