[GitHub] [cassandra] adelapena commented on a diff in pull request #1892: CASSANDRA-17941 trunk: CQL data masking functions

[GitBox <gi...@apache.org>]

adelapena commented on code in PR #1892:
URL: https://github.com/apache/cassandra/pull/1892#discussion_r1052306497


##########
src/java/org/apache/cassandra/cql3/functions/FunctionResolver.java:
##########
@@ -99,6 +100,7 @@ private static Collection<Function> collectCandidates(String keyspace,
             candidates.addAll(NativeFunctions.instance.getFunctions(name));
             candidates.addAll(NativeFunctions.instance.getFactories(name).stream()
                                             .map(f -> f.getOrCreateFunction(providedArgs, receiverType, receiverKs, receiverCf))
+                                            .filter(Objects::nonNull)

Review Comment:
   Agree, added a comment on the JavaDoc for `getOrCreateFunction`, and also in the one for the internal `doGetOrCreateFunction`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org