You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/12/09 07:33:50 UTC
[kudu-CR] [common] small optimisation on PartitionContainsRow
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19333
Change subject: [common] small optimisation on PartitionContainsRow
......................................................................
[common] small optimisation on PartitionContainsRow
This patch updates PartitionSchema::PartitionContainsRow() to avoid
calling EncodeColumns() twice for the same data.
That's to improve performance of Tablet::CheckRowInTablet() which
is in a hot path when inserting data into a tablet.
Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
---
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
2 files changed, 16 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/19333/1
--
To view, visit http://gerrit.cloudera.org:8080/19333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Gerrit-Change-Number: 19333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [common] small optimisation on PartitionContainsRow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19333 )
Change subject: [common] small optimisation on PartitionContainsRow
......................................................................
[common] small optimisation on PartitionContainsRow
This patch updates PartitionSchema::PartitionContainsRow() to avoid
calling EncodeColumns() twice for the same data.
That's to improve performance of Tablet::CheckRowInTablet() which
is in a hot path when inserting data into a tablet.
Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Reviewed-on: http://gerrit.cloudera.org:8080/19333
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
2 files changed, 16 insertions(+), 8 deletions(-)
Approvals:
Alexey Serbin: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Gerrit-Change-Number: 19333
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [common] small optimisation on PartitionContainsRow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19333 )
Change subject: [common] small optimisation on PartitionContainsRow
......................................................................
Patch Set 1: Verified+1
unrelated test failure in TserverAddedDuringRebalancingTest.TserverStarts/1
--
To view, visit http://gerrit.cloudera.org:8080/19333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Gerrit-Change-Number: 19333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 15:58:55 +0000
Gerrit-HasComments: No
[kudu-CR] [common] small optimisation on PartitionContainsRow
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19333 )
Change subject: [common] small optimisation on PartitionContainsRow
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Gerrit-Change-Number: 19333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Dec 2022 17:29:20 +0000
Gerrit-HasComments: No
[kudu-CR] [common] small optimisation on PartitionContainsRow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [common] small optimisation on PartitionContainsRow
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Gerrit-Change-Number: 19333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [common] small optimisation on PartitionContainsRow
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19333 )
Change subject: [common] small optimisation on PartitionContainsRow
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
Thank you for the review!
--
To view, visit http://gerrit.cloudera.org:8080/19333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf1d8a9ea533a859d218292a6a0e2a0818781111
Gerrit-Change-Number: 19333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Dec 2022 17:40:42 +0000
Gerrit-HasComments: No