You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/30 15:57:40 UTC
[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #2305: [WIP][improve][UT] Upgrade junit to 5.+
ashulin opened a new pull request, #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Right now, we still use junit 4.+ in our repo, I hope we can upgrade to [Junit 5.+](https://junit.org/junit5/docs/current/user-guide/#writing-tests), then we can easy to write the UT, JUnit 5 provide some useful feature, e.g. @ParameterizedTest, @EnabledOnOs,...
https://github.com/apache/incubator-seatunnel/issues/2283
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2305: [improve][UT] Upgrade junit to 5.+
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305#discussion_r934291021
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -28,7 +28,7 @@ apacheds-i18n-2.0.0-M15.jar
apacheds-kerberos-codec-2.0.0-M15.jar
api-asn1-api-1.0.0-M20.jar
api-util-1.0.0-M20.jar
-apiguardian-api-1.1.0.jar
+apiguardian-api-1.1.2.jar
Review Comment:
https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2305: [improve][UT] Upgrade junit to 5.+
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2305: [improve][UT] Upgrade junit to 5.+
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305#discussion_r934199363
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -28,7 +28,7 @@ apacheds-i18n-2.0.0-M15.jar
apacheds-kerberos-codec-2.0.0-M15.jar
api-asn1-api-1.0.0-M20.jar
api-util-1.0.0-M20.jar
-apiguardian-api-1.1.0.jar
+apiguardian-api-1.1.2.jar
Review Comment:
It upgrades because of `junit-jupiter-engine` in Junit 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2305: [improve][UT] Upgrade junit to 5.+
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305#discussion_r934290771
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -28,7 +28,7 @@ apacheds-i18n-2.0.0-M15.jar
apacheds-kerberos-codec-2.0.0-M15.jar
api-asn1-api-1.0.0-M20.jar
api-util-1.0.0-M20.jar
-apiguardian-api-1.1.0.jar
+apiguardian-api-1.1.2.jar
Review Comment:
got it. It seems that other components also depend on this jar. Please follow this document to add the corresponding license changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2305: [improve][UT] Upgrade junit to 5.+
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305#discussion_r934127248
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -28,7 +28,7 @@ apacheds-i18n-2.0.0-M15.jar
apacheds-kerberos-codec-2.0.0-M15.jar
api-asn1-api-1.0.0-M20.jar
api-util-1.0.0-M20.jar
-apiguardian-api-1.1.0.jar
+apiguardian-api-1.1.2.jar
Review Comment:
hi, Ilooked this PR and it's good overall, but I have a question, the jars we introduce are all at the test level, why is there a jar upgrade? Can you check where it was imported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2305: [improve][UT] Upgrade junit to 5.+
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2305:
URL: https://github.com/apache/incubator-seatunnel/pull/2305#issuecomment-1200568564
Please trigger the Github action again. @CalvinKirs @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org