[GitHub] [lucene] jprinet commented on a change in pull request #421: LUCENE-10195: Add gradle cache option and make some tasks cacheable

[GitBox <gi...@apache.org>]

jprinet commented on a change in pull request #421:
URL: https://github.com/apache/lucene/pull/421#discussion_r740939233



##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -284,8 +300,14 @@ class RenderJavadocTask extends DefaultTask {
   @Input
   boolean relativeProjectLinks = false
 
-  @Input
-  def offlineLinks = [:]
+  @Internal
+  Map<String, File> offlineLinks = [:]
+
+  // Computes cacheable inputs from the map in offlineLinks.
+  @Nested

Review comment:
       nice job

##########
File path: gradle/generation/local-settings.gradle
##########
@@ -55,6 +55,11 @@ org.gradle.jvmargs=-Xmx3g \\
 org.gradle.parallel=true
 org.gradle.priority=normal
 
+# This setting enables local task output caches. This will speed up
+# your local builds in most cases but will also consume disk space in your
+# gradle home. See LUCENE-10195 and/or SOLR-15603 for details.
+# org.gradle.caching=true

Review comment:
       I think it's good to have it commented out and documented that way 👍




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org