You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/07 15:49:01 UTC
[GitHub] [kafka] mimaison commented on a diff in pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation
mimaison commented on code in PR #11473:
URL: https://github.com/apache/kafka/pull/11473#discussion_r891403316
##########
docs/ops.html:
##########
@@ -1469,33 +1489,38 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
</tr>
<tr>
<td>Byte out rate to clients</td>
- <td>kafka.server:type=BrokerTopicMetrics,name=BytesOutPerSec</td>
- <td></td>
+ <td>kafka.server:type=BrokerTopicMetrics,name=BytesOutPerSec,topic=([-.\w]+)</td>
+ <td>Byte out (to the clients) rate per topic. Omitting 'topic=(...)' will yield the all-topic rate.</td>
</tr>
<tr>
<td>Byte out rate to other brokers</td>
- <td>kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesOutPerSec</td>
- <td></td>
+ <td>kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesOutPerSec,topic=([-.\w]+)</td>
+ <td>Byte out (to the other brokers) rate per topic. Omitting 'topic=(...)' will yield the all-topic rate.</td>
+ </tr>
+ <tr>
+ <td>Rejected byte rate</td>
+ <td>kafka.server:type=BrokerTopicMetrics,name=BytesRejectedPerSec,topic=([-.\w]+)</td>
+ <td>Rejected byte rate per topic, due to the record batch size is greater than max.message.bytes configuration. Omitting 'topic=(...)' will yield the all-topic rate.</td>
Review Comment:
`is greater` -> `being greater`
##########
docs/ops.html:
##########
@@ -1460,7 +1480,7 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<tr>
<td>Message conversion rate</td>
<td>kafka.server:type=BrokerTopicMetrics,name={Produce|Fetch}MessageConversionsPerSec,topic=([-.\w]+)</td>
- <td>Number of records which required message format conversion.</td>
+ <td>Message format conversion rate, by Produce or Fetch request, per topic. Omitting 'topic=(...)' will yield the all-topic rate.</td>
Review Comment:
`by Produce or Fetch request` -> `for Produce or Fetch requests`
##########
docs/ops.html:
##########
@@ -1440,7 +1440,27 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<td>Error rate</td>
<td>kafka.network:type=RequestMetrics,name=ErrorsPerSec,request=([-.\w]+),error=([-.\w]+)</td>
<td>Number of errors in responses counted per-request-type, per-error-code. If a response contains
- multiple errors, all are counted. error=NONE indicates successful responses.</td>
+ multiple errors, all are counted. error=NONE indicates successful responses.</td>
+ </tr>
+ <tr>
+ <td>Produce request rate</td>
+ <td>kafka.server:type=BrokerTopicMetrics,name=TotalProduceRequestsPerSec,topic=([-.\w]+)</td>
+ <td>Produce request rate per topic. Omitting 'topic=(...)' will yield the all-topic rate.</td>
+ </tr>
+ <tr>
+ <td>Fetch request rate</td>
+ <td>kafka.server:type=BrokerTopicMetrics,name=TotalFetchRequestsPerSec,topic=([-.\w]+)</td>
+ <td>Fetch request (from client or follower) rate per topic. Omitting 'topic=(...)' will yield the all-topic rate.</td>
Review Comment:
`from client or follower` -> `from clients or followers`. Same below
##########
docs/ops.html:
##########
@@ -1739,12 +1764,12 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<tr>
<td>Outgoing byte rate of reassignment traffic</td>
<td>kafka.server:type=BrokerTopicMetrics,name=ReassignmentBytesOutPerSec</td>
- <td></td>
+ <td>0; non-zero when the partition reassignment is in progress.</td>
Review Comment:
`the partition reassignment` -> `a partition reassignment`
Same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org