You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/02/09 17:43:18 UTC
Review Request 43364: GEODE-948: gemfire-modules-assembly should not
publish a jar artifact
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43364/
-----------------------------------------------------------
Review request for geode and Anthony Baker.
Repository: geode
Description
-------
GEODE-948: gemfire-modules-assembly should not publish a jar artifact
Diffs
-----
extensions/gemfire-modules-assembly/build.gradle 270e16718e5dc20709ad9f4f5ff47c08856e03f6
Diff: https://reviews.apache.org/r/43364/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 43364: GEODE-948: gemfire-modules-assembly should
not publish a jar artifact
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43364/#review118424
-----------------------------------------------------------
Adding the disableMavenPublishing closure in a commmon Gradle script is a good move.
- Mark Bretl
On Feb. 9, 2016, 9:21 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43364/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 9:21 a.m.)
>
>
> Review request for geode and Anthony Baker.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-948: gemfire-modules-assembly should not publish a jar artifact
>
>
> Diffs
> -----
>
> extensions/gemfire-modules-assembly/build.gradle 270e16718e5dc20709ad9f4f5ff47c08856e03f6
> gemfire-assembly/build.gradle c77d90920f80c45c9f6ee483eacc1762ebad8e49
> gradle/utilities.gradle 18aef202d9c43bd1c6e0171ffad761b065ea7beb
>
> Diff: https://reviews.apache.org/r/43364/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 43364: GEODE-948: gemfire-modules-assembly should
not publish a jar artifact
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43364/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 5:21 p.m.)
Review request for geode and Anthony Baker.
Changes
-------
Added a disableMavenPublishing() closure.
Repository: geode
Description
-------
GEODE-948: gemfire-modules-assembly should not publish a jar artifact
Diffs (updated)
-----
extensions/gemfire-modules-assembly/build.gradle 270e16718e5dc20709ad9f4f5ff47c08856e03f6
gemfire-assembly/build.gradle c77d90920f80c45c9f6ee483eacc1762ebad8e49
gradle/utilities.gradle 18aef202d9c43bd1c6e0171ffad761b065ea7beb
Diff: https://reviews.apache.org/r/43364/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 43364: GEODE-948: gemfire-modules-assembly should
not publish a jar artifact
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43364/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 5:19 p.m.)
Review request for geode and Anthony Baker.
Repository: geode
Description
-------
GEODE-948: gemfire-modules-assembly should not publish a jar artifact
Diffs
-----
extensions/gemfire-modules-assembly/build.gradle 270e16718e5dc20709ad9f4f5ff47c08856e03f6
Diff: https://reviews.apache.org/r/43364/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 43364: GEODE-948: gemfire-modules-assembly should
not publish a jar artifact
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43364/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 5:08 p.m.)
Review request for geode and Anthony Baker.
Repository: geode
Description
-------
GEODE-948: gemfire-modules-assembly should not publish a jar artifact
Diffs (updated)
-----
extensions/gemfire-modules-assembly/build.gradle 270e16718e5dc20709ad9f4f5ff47c08856e03f6
Diff: https://reviews.apache.org/r/43364/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 43364: GEODE-948: gemfire-modules-assembly should
not publish a jar artifact
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43364/#review118409
-----------------------------------------------------------
extensions/gemfire-modules-assembly/build.gradle (line 34)
<https://reviews.apache.org/r/43364/#comment179633>
Could we extract this could into a method on `gradle/utilities.gradle`? Something like:
```
disableMavenPublishingOnAssemblyProjectBecauseGradleIsSilly = {
...
}
```
Then we could call the closure from both gemfire-assembly and gemfire-modules-assembly.
- Anthony Baker
On Feb. 9, 2016, 4:43 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43364/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 4:43 p.m.)
>
>
> Review request for geode and Anthony Baker.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-948: gemfire-modules-assembly should not publish a jar artifact
>
>
> Diffs
> -----
>
> extensions/gemfire-modules-assembly/build.gradle 270e16718e5dc20709ad9f4f5ff47c08856e03f6
>
> Diff: https://reviews.apache.org/r/43364/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>