[jira] [Commented] (AVRO-2774) missing @Override annotations in generated code

["Christophe Le Saec (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563202#comment-17563202 ] 

Christophe Le Saec commented on AVRO-2774:
------------------------------------------

Hello,
The linked pull request add @Override annotation by modifying vm file (record.vm & enum.vm), and also add unit test to ensure that all overrides method on generated code have this annotation. 

> missing @Override annotations in generated code
> -----------------------------------------------
>
>                 Key: AVRO-2774
>                 URL: https://issues.apache.org/jira/browse/AVRO-2774
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.9.1, 1.9.2
>         Environment: openjdk version "11.0.6" 2020-01-14 LTS
> avro 1.9.2
> gradle avro plugin
>            Reporter: Tim Spriggs
>            Priority: Major
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When applying errorProne to my project, I get errors from the MissingOverride rule. eg:
> error: [MissingOverride] getSpecificData overrides method in SpecificRecordBase
> error: [MissingOverride] getSchema implements method in SpecificRecordBase
> error: [MissingOverride] get implements method in SpecificRecordBase
> error: [MissingOverride] put implements method in SpecificRecordBase
>  
> If these are always tagged with @Override then static analysis and IDE hints perform better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)