You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "piby180 (via GitHub)" <gi...@apache.org> on 2024/05/03 13:39:51 UTC

[I] Allow ability to customize failureThreshold and timeoutSeconds in stateful sets. [pinot]

piby180 opened a new issue, #13073:
URL: https://github.com/apache/pinot/issues/13073

   We do not have any ability to customize failureThreshold (and also timeoutSeconds) in the helm chart
   
   https://github.com/apache/pinot/blob/31ae6a32aa426a6b9364b75e774a5e80c37eb336/helm/pinot/templates/server/statefulset.yaml#L88
   
   This is needed to prevent fcontinuous failing of pods in a loop during pod restarts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] Allow more flexibility to customize probes in statefulsets [pinot]

Posted by "piby180 (via GitHub)" <gi...@apache.org>.
piby180 closed issue #13073: Allow more flexibility to customize probes in statefulsets
URL: https://github.com/apache/pinot/issues/13073


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] Allow more flexibility to customize probes in statefulsets [pinot]

Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #13073:
URL: https://github.com/apache/pinot/issues/13073#issuecomment-2128325088

   We can close this issue. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] Allow ability to customize failureThreshold and timeoutSeconds in stateful sets. [pinot]

Posted by "piby180 (via GitHub)" <gi...@apache.org>.
piby180 commented on issue #13073:
URL: https://github.com/apache/pinot/issues/13073#issuecomment-2094046254

   Hi @abhioncbr 
   I spent quite some time reading about probes last night. 
   
   To summarize, we need the following additional options for every probe in each statefulset.
   
   1. `successThreshold`
   2. `failureThreshold`
   3. `timeoutSeconds`
   
   In addition, we are using readiness and liveness probes but not startup probes. The server pods need an initial startup time where it marks the segments online. This startup time is different for different cluster depending on the number of segments stored. Instead of a static startup delay using `initialDelaySeconds` in readiness and liveness probes, it makes sense to use startup probe instead. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] Allow more flexibility to customize probes in statefulsets [pinot]

Posted by "piby180 (via GitHub)" <gi...@apache.org>.
piby180 commented on issue #13073:
URL: https://github.com/apache/pinot/issues/13073#issuecomment-2128667315

   @abhioncbr Thanks for the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [I] Allow ability to customize failureThreshold and timeoutSeconds in stateful sets. [pinot]

Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #13073:
URL: https://github.com/apache/pinot/issues/13073#issuecomment-2093792915

   I am planning to work on this; please assign it to me. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org