You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/29 00:29:15 UTC
[GitHub] [incubator-pinot] mayankshriv opened a new pull request #5465: Support distinctCountRawThetaSketch aggregation that returns serialized sketch.
mayankshriv opened a new pull request #5465:
URL: https://github.com/apache/incubator-pinot/pull/5465
1. Support a variation of theta sketch based distinct count aggregation function that returns
serialized bytes of the final aggregated sketch, instead of the actual distinct value.
2. The return value is hex encoded String of the serialized sketch bytes. This can be
deserialized at the client side by the library using org.apache.commons.codec.binary as:
`Hex.decodeHex(stringValue.toCharArray())`. This is the same as any other byte[] value
returned by Pinot.
3. Added unit test for the new aggregation function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv merged pull request #5465: Support distinctCountRawThetaSketch aggregation that returns serialized sketch.
Posted by GitBox <gi...@apache.org>.
mayankshriv merged pull request #5465:
URL: https://github.com/apache/incubator-pinot/pull/5465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5465: Support distinctCountRawThetaSketch aggregation that returns serialized sketch.
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on a change in pull request #5465:
URL: https://github.com/apache/incubator-pinot/pull/5465#discussion_r432909781
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##########
@@ -137,6 +137,8 @@ public static AggregationFunction getAggregationFunction(AggregationInfo aggrega
return new FastHLLAggregationFunction(column);
case DISTINCTCOUNTTHETASKETCH:
return new DistinctCountThetaSketchAggregationFunction(arguments);
+ case DISTINCTCOUNTRAWTHETASKETCH:
Review comment:
Agree, but following the convention of the distinctCountRawHLL. Perhaphs we can alias them both later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5465: Support distinctCountRawThetaSketch aggregation that returns serialized sketch.
Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #5465:
URL: https://github.com/apache/incubator-pinot/pull/5465#discussion_r432689807
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##########
@@ -137,6 +137,8 @@ public static AggregationFunction getAggregationFunction(AggregationInfo aggrega
return new FastHLLAggregationFunction(column);
case DISTINCTCOUNTTHETASKETCH:
return new DistinctCountThetaSketchAggregationFunction(arguments);
+ case DISTINCTCOUNTRAWTHETASKETCH:
Review comment:
this should not be called distinctCount right, you can do anything with thetasketch. maybe just RAWTHETASKETCH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org