You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/10/09 17:22:40 UTC
[GitHub] tinkerpop pull request #730: TINKERPOP-1797: LambdaRestrictionStrategy and L...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/730
TINKERPOP-1797: LambdaRestrictionStrategy and LambdaMapStep in by()-modulation.
https://issues.apache.org/jira/browse/TINKERPOP-1797
We have had too many problems with `LambdaRestrictionStrategy` because it is difficult to know what is a true lambda. I have now simply hardcoded the lambda determination as a `String` analysis of the lambda object for Java, Groovy, and Python. As we add more GLVs, we can add more string mappers. Every other solution thus far has either been too lenient or too restrictive.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1797
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/730.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #730
----
commit 46ac055f747390eefb58ac7ab7ef4c9fc178aaec
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-10-09T17:20:26Z
We have had so many problems with LambdaRestrictionStragegy because it is difficult to know what is a true lambda. I have now simply hardcoded the lambda determination as a String analysis of the lambda object for Java, Groovy, and Python. As we add more GLVs, we can add more string mappers. Any other solution thus far has either been too lenient or too restrictive. Added more test cases to LambdaRestrictionStrategyTest as well.
----
---
[GitHub] tinkerpop issue #730: TINKERPOP-1797: LambdaRestrictionStrategy and LambdaMa...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/730
VOTE: +1
---
[GitHub] tinkerpop pull request #730: TINKERPOP-1797: LambdaRestrictionStrategy and L...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/730
---
[GitHub] tinkerpop issue #730: TINKERPOP-1797: LambdaRestrictionStrategy and LambdaMa...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/730
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---