You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "aortiz-WW (via GitHub)" <gi...@apache.org> on 2023/01/23 19:17:23 UTC

[GitHub] [superset] aortiz-WW opened a new issue, #22829: Can't get UI to change again

aortiz-WW opened a new issue, #22829:
URL: https://github.com/apache/superset/issues/22829

### A clear and concise description of what the bug is.
I'm trying to change the UI of superset. I want to add a banner at the top of the page and at the bottom. I have already done so by following these links:
https://superset.apache.org/docs/installation/installing-superset-using-docker-compose/
https://github.com/apache/superset/issues/22758
#### How to reproduce the bug
I first clone the repo. Then I go inside the `superset-frontend/src/views/components/` directory. Inside the Menu.tsx, I add to the Menuwrapper component my banner as such:
```
return <>

<div id='banner' style={{backgrounColor: 'green', color: 'white', textAlign: 'center}}>Unclassified</div>
<Menu data={newMenuData} {...rest}/>
</>
```
Then I run the docker-compose pull and up explained in the first link above.
### Expected results
I expect to see changes in the banner after adding changes. It appeared once I made the changes and then if I want to make other changes, it doesn't appear

### Actual results

Nothing changes after the initial change

#### Screenshots

If applicable, add screenshots to help explain your problem.

### Environment

Using apache/superset on windows hosted VM running Ubuntu 22. Everything is ran using vs code.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on issue #22829: Can't get UI to change again

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #22829:
URL: https://github.com/apache/superset/issues/22829#issuecomment-1402412262

Closing since it's not a bug, but a developer experience issue. I assure you, it does work!

When running the vanilla `docker-compose up` in your terminal, and you make a file change in the frontend directory, you'll see in your terminal that Webpack starts rebuilding. This takes time! You will not see the changes right away, but they will happen, and you will need to refresh the browser when they do.

Also, you can start a second terminal process, cd into `superset-frontend` and do `npm run dev-server`. This runs a dev mode process (with hot reloading) that proxies to your original Superset server process, and runs on port 9000 instead. However, this means you have TWO webpack builds running concurrently, so you might want to turn off the original docker webpack process by commenting out a line in the `docker-frontend` file.

Hope that helps!

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] aortiz-WW commented on issue #22829: Can't get UI to change again

Posted by "aortiz-WW (via GitHub)" <gi...@apache.org>.

aortiz-WW commented on issue #22829:
URL: https://github.com/apache/superset/issues/22829#issuecomment-1405422088

   
   > Closing since it's not a bug, but a developer experience issue. I assure you, it does work!
   > 
   > When running the vanilla `docker-compose up` in your terminal, and you make a file change in the frontend directory, you'll see in your terminal that Webpack starts rebuilding. This takes time! You will not see the changes right away, but they will happen, and you will need to refresh the browser when they do.
   > 
   > Also, you can start a second terminal process, cd into `superset-frontend` and do `npm run dev-server`. This runs a dev mode process (with hot reloading) that proxies to your original Superset server process, and runs on port 9000 instead. However, this means you have TWO webpack builds running concurrently, so you might want to turn off the original docker webpack process by commenting out a line in the `docker-frontend` file.
   > 
   > Hope that helps!
   
   How much time would you say? In my case, I have waited more than half an hour and nothing happened
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas closed issue #22829: Can't get UI to change again

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas closed issue #22829: Can't get UI to change again
URL: https://github.com/apache/superset/issues/22829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on issue #22829: Can't get UI to change again

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #22829:
URL: https://github.com/apache/superset/issues/22829#issuecomment-1405668054

   Oh jeez... should be less than a minute, depending on computer. Try the other approach I mentioned running webpack separately in a second terminal. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org