You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/05 12:05:16 UTC

[GitHub] [druid] bananaaggle commented on pull request #11240: Add apache rocketmq based indexing service

bananaaggle commented on pull request #11240:
URL: https://github.com/apache/druid/pull/11240#issuecomment-855230432


   Hi, @clintropolis good weekend! I've added a new extension for rocketmq indexing service. I tested it on a tiny Druid cluster and it worked as expected. Last month, I create unit tests for it which is as same as Kafka indexing service and Kinesis indexing service. I don't know who can review this feature. Could you please tell me who can review this feature in community? Those 13000+ lines code include 10000 lines unit test, so do you think should I delete some of them and move some tests to another PR? I worry about reviewing those code is a heavy work and no one will take it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org