You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/08/16 16:17:25 UTC
[Impala-ASF-CR] IMPALA-11195: (Addendum) fix build on older OpenSSL
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20370
Change subject: IMPALA-11195: (Addendum) fix build on older OpenSSL
......................................................................
IMPALA-11195: (Addendum) fix build on older OpenSSL
Caught by tests on CentOS 7.9. Upstream test infrastructure all use
newer OpenSSL.
Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
---
M be/src/thirdparty/squeasel/squeasel.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/20370/1
--
To view, visit http://gerrit.cloudera.org:8080/20370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
Gerrit-Change-Number: 20370
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11195: (Addendum) fix build on older OpenSSL
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20370 )
Change subject: IMPALA-11195: (Addendum) fix build on older OpenSSL
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/20370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
Gerrit-Change-Number: 20370
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 17:05:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11195: (Addendum) fix build on older OpenSSL
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20370 )
Change subject: IMPALA-11195: (Addendum) fix build on older OpenSSL
......................................................................
IMPALA-11195: (Addendum) fix build on older OpenSSL
Caught by tests on CentOS 7.9. Upstream test infrastructure all use
newer OpenSSL.
Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
Reviewed-on: http://gerrit.cloudera.org:8080/20370
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M be/src/thirdparty/squeasel/squeasel.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
Gerrit-Change-Number: 20370
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11195: (Addendum) fix build on older OpenSSL
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20370 )
Change subject: IMPALA-11195: (Addendum) fix build on older OpenSSL
......................................................................
Patch Set 1: Verified+1
Verified in local and other builds. This code is not executed in upstream tests.
--
To view, visit http://gerrit.cloudera.org:8080/20370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
Gerrit-Change-Number: 20370
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 17:37:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11195: (Addendum) fix build on older OpenSSL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20370 )
Change subject: IMPALA-11195: (Addendum) fix build on older OpenSSL
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13764/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b22a14a5baca6ca5e87dd3840f78f6697462d8
Gerrit-Change-Number: 20370
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 16:43:17 +0000
Gerrit-HasComments: No