[GitHub] [incubator-pinot] snleee commented on a change in pull request #3942: Set processingException when all queried segments cannot be acquired

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #3942: Set processingException when all queried segments cannot be acquired
URL: https://github.com/apache/incubator-pinot/pull/3942#discussion_r265416243
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/TableDataManager.java
 ##########
 @@ -79,6 +79,16 @@ void addSegment(@Nonnull String segmentName, @Nonnull TableConfig tableConfig,
    */
   void removeSegment(@Nonnull String segmentName);
 
+  /**
+   * Track a deleted segment.
+   */
+  void deleteSegment(@Nonnull String segmentName);
 
 Review comment:
   Can we rename this function? `deleteSegment` sounds like we are deleting segments instead of book-keeping.  It's confusing since we have another method called `removeSegment`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org