You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/07/01 02:53:19 UTC

[kudu-CR] Make dist test.py work on a symlinked work directory

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3551

to review the following change.

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................

Make dist_test.py work on a symlinked work directory

Previously, if run inside a directory that was under a symlink,
dist_test.py would not correctly determine whether libraries were from
the system or from the Kudu build. This would cause run_dist_test.py to
incorrectly put all libraries in LD_LIBRARY_PATH. This could result in
errors that looked like the following when trying to symbolize stack
traces under TSAN:

/tmp/run_tha_testQiFa2H/thirdparty/installed/bin/llvm-symbolizer: symbol lookup error:
/tmp/run_tha_testQiFa2H/build/dist-test-system-libs/libstdc++.so.6: undefined symbol: __tsan_init

With these changes, classification of system vs Kudu build libraries
works correctly under those conditions, and symbolization now works.

run_dist_test.py just has a cosmetic change to rename a variable for
clarity. No functional changes.

Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
---
M build-support/dist_test.py
M build-support/run_dist_test.py
2 files changed, 36 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/3551/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Make dist test.py work on a symlinked work directory

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2431/

-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Make dist test.py work on a symlinked work directory

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3551

to look at the new patch set (#2).

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................

Make dist_test.py work on a symlinked work directory

Previously, if run inside a directory that was partially composed of
symlinks, dist_test.py would not correctly collect and modify the RPATHs
of thirdparty libraries. It would put everything in LD_LIBRARY_PATH.
This could result in errors that looked like the following when trying
to symbolize stack traces under TSAN:

/tmp/run_tha_testQiFa2H/thirdparty/installed/bin/llvm-symbolizer: symbol lookup error:
/tmp/run_tha_testQiFa2H/build/dist-test-system-libs/libstdc++.so.6: undefined symbol: __tsan_init

With these changes, symbolization works.

run_dist_test.py just has a cosmetic change to rename a variable for
clarity. No functional changes.

Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
---
M build-support/dist_test.py
M build-support/run_dist_test.py
2 files changed, 38 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/3551/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Make dist test.py work on a symlinked work directory

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2144/

-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Make dist test.py work on a symlinked work directory

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................


Abandoned

This is a pretty gross hack and a better thing to do is use `mount` instead of a symlink for the source directory.

-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Make dist test.py work on a symlinked work directory

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/3551 )

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................


Patch Set 2:

This bit me today.  I resurrected that patch, but it's broken and can't spend any more time on this.  Going to go the bind mount route.  https://github.com/danburkert/kudu/tree/dist-test-symlink


-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-Change-Number: 3551
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 22 Jun 2018 00:33:40 +0000
Gerrit-HasComments: No