[superset] branch sc_71594 updated (e62bea2b84 -> edd7bf572b)

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a change to branch sc_71594
in repository https://gitbox.apache.org/repos/asf/superset.git


    omit e62bea2b84 Add test
     new edd7bf572b Add test

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (e62bea2b84)
            \
             N -- N -- N   refs/heads/sc_71594 (edd7bf572b)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../src/components/ErrorMessage/MarshmallowErrorMessage.test.tsx        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[superset] 01/01: Add test

[be...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch sc_71594
in repository https://gitbox.apache.org/repos/asf/superset.git

commit edd7bf572b993d4f63e754c03eae114716ec1297
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Mon Oct 2 17:04:29 2023 -0700

    Add test
---
 .../ErrorMessage/MarshmallowErrorMessage.test.tsx  | 86 ++++++++++++++++++++++
 1 file changed, 86 insertions(+)

diff --git a/superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.test.tsx b/superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.test.tsx
new file mode 100644
index 0000000000..5fd6ee7bfb
--- /dev/null
+++ b/superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.test.tsx
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { render, screen, fireEvent } from '@testing-library/react';
+import '@testing-library/jest-dom/extend-expect';
+import { ThemeProvider, supersetTheme } from '@superset-ui/core';
+import { ErrorLevel, ErrorTypeEnum } from 'src/components/ErrorMessage/types';
+import MarshmallowErrorMessage from './MarshmallowErrorMessage';
+
+describe('MarshmallowErrorMessage', () => {
+  const mockError = {
+    extra: {
+      messages: {
+        name: ["can't be blank"],
+        age: {
+          inner: ['is too low'],
+        },
+      },
+      payload: {
+        name: '',
+        age: {
+          inner: 10,
+        },
+      },
+      issue_codes: [],
+    },
+    message: 'Validation failed',
+    error_type: ErrorTypeEnum.MARSHMALLOW_ERROR,
+    level: 'error' as ErrorLevel,
+  };
+
+  test('renders without crashing', () => {
+    render(
+      <ThemeProvider theme={supersetTheme}>
+        <MarshmallowErrorMessage error={mockError} />
+      </ThemeProvider>,
+    );
+    expect(screen.getByText('Validation failed')).toBeInTheDocument();
+  });
+
+  test('renders the provided subtitle', () => {
+    render(
+      <ThemeProvider theme={supersetTheme}>
+        <MarshmallowErrorMessage error={mockError} subtitle="Error Alert" />
+      </ThemeProvider>,
+    );
+    expect(screen.getByText('Error Alert')).toBeInTheDocument();
+  });
+
+  test('renders extracted invalid values', () => {
+    render(
+      <ThemeProvider theme={supersetTheme}>
+        <MarshmallowErrorMessage error={mockError} />
+      </ThemeProvider>,
+    );
+    expect(screen.getByText("can't be blank:")).toBeInTheDocument();
+    expect(screen.getByText('is too low: 10')).toBeInTheDocument();
+  });
+
+  test('renders the JSONTree when details are expanded', () => {
+    render(
+      <ThemeProvider theme={supersetTheme}>
+        <MarshmallowErrorMessage error={mockError} />
+      </ThemeProvider>,
+    );
+    fireEvent.click(screen.getByText('Details'));
+    expect(screen.getByText('"can\'t be blank"')).toBeInTheDocument();
+  });
+});