Re: Checks on 1.4 Release

[Greg Brown <gk...@mac.com>]

Forwarding to pivot-dev - didn't realize the original message wasn't on the dev list.

In response to the localization issue - I think you identified a valid bug. The app was calling the static Locale.setDefault() method - if the second applet started before the first one, it would set the locale to German and the first one would pick it up. This is now fixed (however, I don't think it should hold up the release - the fix can go out in 1.4.1).

Thanks,
G

On Dec 29, 2009, at 9:10 AM, Greg Brown wrote:

>> Test platform: Win XP SP3, Sun JDK 6 Update 17 (32 bit), inside Firefox 3.5.6
>>  
>> - all jsp pages (from tutorials for example) calls external Javascript resources, like this:
>> <script src="http://alexgorbatchev.com/pub/sh/current/scripts/shCore.js" type="text/javascript"></script>
>> is this right (in licensing terms) ?
> 
> Yes - we can't include the syntax coloring JS in the release because it is LGPL. However, we are allowed to link to it as long as we include this comment in the HTML page:
> 
> <!-- NOTE: Syntax highlighting script is LGPL -->
>  
>> - localization tutorial (here: http://localhost:8080/pivot-tutorials/localization.html):
>> the second applet (at the bottom of the page uses the fixed German locale, Ok),
>> but the first (at the top of the page) shown the German locale (and in html source startupProperties are not set for this)
>> and not the user locale (in my case Italian) or the default (English)
>> -- no, sorry but the problem here seems to be with Firefox 3.5.6, because in IE 7 or upper I see all good ... someone has the same problem ? and on other platforms too ?
> 
> I'm not sure I understand the problem. Are you saying that both applets appear in German?
> 
>> Improvements for the 1.4.1 (could become JIRA tasks for the 1.4.1):
>>  
>> - effects\Blur doesn't take all image pixels, it leave 1 pixel without effect at any image size, is it wanted ?
> 
> This is a known issue (not sure if it is in JIRA yet, though).
>  
>> - note that jnlp files are not-so-much human-readable, they haven't line feeds inside (at least on windows),
>> but probably this could be an improvement task for the 1.4.1
> 
> JNLP files don't really need to be human-readable. I'd actually suggest leaving them as-is.
> 
>> - in the source of many (generated) html pages, I see that for example in pre tags,
>>   all < and > chars are generated (by xslt transformations I think) in the html escaped way, that's Ok
>>   (browsers don't complain on them) but it's less human-readable (only manually reading page sources) ...
>> again, probably this could be an improvement task for the 1.4.1
> 
> Same as above.
>  
>> - for 1.4.1, also in textArea handle Home and End keys and maybe also <CTRL> Home and <CTRL> End ...
> 
> We have a JIRA ticket to enhance keyboard navigation in TextInput and TextArea for 1.4.1. Feel free to add this as a comment to that ticket.
> 
>> - for 1.4.1, as seen in the Kitchen Sink Demo: expanders expand clicking on the arrow (Ok)
>>   or with double click on the title text, while accordions expand/shrink with a single click on the title text ...
> 
> Are you suggesting that they should both behave the same in response to mouse clicks? The current behavior is actually by design (it is consistent with similar widgets on other platforms), so I'm not sure we should change it.
> 
>> Sorry, a last little thing, as seen in the source zip:
>>  
>> - as reported in BUILD file:
>> Maven Ant Tasks 2.0.10 or greater
>> but should be 2.1.0 ... or at least using the 2.0.10 jar all works the same ?
> 
> 2.0.10 is correct.
>