You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/23 09:27:18 UTC

[GitHub] [tvm] apeskov commented on pull request #12323: The change allows to increase performance in multi-thread environment.

apeskov commented on PR #12323:
URL: https://github.com/apache/tvm/pull/12323#issuecomment-1223805016

   The word "Global" means that it's a global singleton. Changing semantic to thread local will confuse developers. 
   
   Moreover, this patch works only because you initialise VirtualMachine modules form separate threads. That is not mandatory behaviour. Customer may create a set of VirtualMachine in main thread and after that assign them to worker sub threads.
   
   This change is good enough to demonstrate possibility of advance memory management in case of multi instance execution. But it cannot be merged as is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org