You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2020/08/17 03:21:34 UTC
[incubator-superset] branch master updated: fixing console error
about bad html attribute (#10604)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new ed9b6db fixing console error about bad html attribute (#10604)
ed9b6db is described below
commit ed9b6dbf2bd4a85835004752d1c34f664dfeb804
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Sun Aug 16 20:21:21 2020 -0700
fixing console error about bad html attribute (#10604)
---
superset-frontend/src/components/Button/index.tsx | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/components/Button/index.tsx b/superset-frontend/src/components/Button/index.tsx
index e306a7a..22b04ed 100644
--- a/superset-frontend/src/components/Button/index.tsx
+++ b/superset-frontend/src/components/Button/index.tsx
@@ -104,10 +104,13 @@ export default function Button(props: ButtonProps) {
<SupersetButton {...buttonProps}>{props.children}</SupersetButton>
);
+ const whittledProps = { ...buttonProps };
+ delete whittledProps.dropdownItems;
+
if (dropdownItems) {
button = (
<div style={BUTTON_WRAPPER_STYLE}>
- <SupersetButton {...buttonProps} data-toggle="dropdown">
+ <SupersetButton {...whittledProps} data-toggle="dropdown">
{props.children}
</SupersetButton>
<ul className="dropdown-menu">