[jira] [Created] (SOLR-14322) AbstractFullDistribZkTestBase.waitForThingsToLevelOut is very inconsistent

["Mike Drob (Jira)" <ji...@apache.org>]

Mike Drob created SOLR-14322:
--------------------------------

             Summary: AbstractFullDistribZkTestBase.waitForThingsToLevelOut is very inconsistent
                 Key: SOLR-14322
                 URL: https://issues.apache.org/jira/browse/SOLR-14322
             Project: Solr
          Issue Type: Task
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Mike Drob


There are many strange things going on with this method - 

1. It accepts a value in seconds, but many callers pass millis
2. The method will only retry on the last shard being inconsistent, not any other shard
3. Catching Throwable is dubious.
4. There's a conditional wait mixed with an unconditional sleep. (this might be ok?)
5. There's a bunch of System.out and System.err
6. If we never get to the "level out state" we still simply return instead of somehow indicating the error condition



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org