You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/21 04:04:32 UTC

[GitHub] [spark] gengliangwang commented on pull request #39148: [DON'T MERGE] Introduce `ProtoBufSerDe` as a SPI

gengliangwang commented on PR #39148:
URL: https://github.com/apache/spark/pull/39148#issuecomment-1360827887

   @LuciferYang how about the following two solutions:
   1. Use annotations. E.g. `ExecutorMetricsJsonSerializer`
   2. We can support registering in `KVStoreProtobufSerializer`, which is similar to `KryoSerializer`. 
   
   So that we don't need to match classes with class name strings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org