You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Deepak Dixit (JIRA)" <ji...@apache.org> on 2010/04/19 13:43:50 UTC
[jira] Created: (OFBIZ-3719) Include DOCTYPE at the begining of CMS
driven html page.
Include DOCTYPE at the begining of CMS driven html page.
--------------------------------------------------------
Key: OFBIZ-3719
URL: https://issues.apache.org/jira/browse/OFBIZ-3719
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/cmssite
Affects Versions: SVN trunk
Reporter: Deepak Dixit
Priority: Minor
Fix For: SVN trunk
Include DOCTYPE at the begining of html pages, that are render through cms.
Currently DOCTYPE is included in HtmlHead.ftl for cms.
By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3719) Include DOCTYPE at the begining of
CMS driven html page.
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858832#action_12858832 ]
Scott Gray commented on OFBIZ-3719:
-----------------------------------
Oh sorry yeah it sounds fine, at least until we can come up with something better.
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3719) Include DOCTYPE at the begining of CMS
driven html page.
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepak Dixit updated OFBIZ-3719:
--------------------------------
Attachment: OFBIZ-3719.patch
here is the patch for this issue.
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3719) Include DOCTYPE at the begining of
CMS driven html page.
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858473#action_12858473 ]
Deepak Dixit commented on OFBIZ-3719:
-------------------------------------
Hello Scott,
These (html , head, body) are included in headerhead.ftl template that are used in main-decorator.For ecommerce DOCTYPE is not included in headerhead.ftl , It is included through HtmlScreenRenderer.java. So if we use same headerhead.ftl for screens and cms then it works fine for screens, But in case of CMS DOCYPE is not included.There for I have added it in CmsEvents.java for CMS so that we can use same headerhead for both (CMS content and non CMS content).
It is good idea to include <html xmlns="http://www.w3.org/1999/xhtml"> in renderScreenBegin method of HtmlScreenRenderer.java and </html> in renderScreenEnd method of HtmlScreenRenderer.java.
But we need to add meta and script tag in headerhead.ftl according to requirement so we can not add them here.
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3719) Include DOCTYPE at the begining of
CMS driven html page.
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858841#action_12858841 ]
Deepak Dixit commented on OFBIZ-3719:
-------------------------------------
Thanks Scott for valuable comments.
And Thanks Ashish for commiting the patch.
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3719) Include DOCTYPE at the begining of
CMS driven html page.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-3719:
------------------------------------------
Assignee: Ashish Vijaywargiya
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3719) Include DOCTYPE at the begining of
CMS driven html page.
Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858829#action_12858829 ]
Deepak Dixit commented on OFBIZ-3719:
-------------------------------------
Hi Scott,
Do you have more concern on this or this patch looks fine to you so that it can be part of trunk.
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3719) Include DOCTYPE at the begining of
CMS driven html page.
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858467#action_12858467 ]
Scott Gray commented on OFBIZ-3719:
-----------------------------------
Hi Deepak,
I'm not sure I understand the benefit, what good is it to render the doctype here when so much more is required of an html document such as html, head and body tags?
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3719) Include DOCTYPE at the begining of CMS
driven html page.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-3719.
--------------------------------------
Resolution: Fixed
Thanks Deepak & Rishi for the contribution - Your changes are committed in trunk at r935886.
Special thanks to Scott for providing useful comments!
--
Ashish Vijaywargiya
> Include DOCTYPE at the begining of CMS driven html page.
> --------------------------------------------------------
>
> Key: OFBIZ-3719
> URL: https://issues.apache.org/jira/browse/OFBIZ-3719
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/cmssite
> Affects Versions: SVN trunk
> Reporter: Deepak Dixit
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3719.patch
>
>
> Include DOCTYPE at the begining of html pages, that are render through cms.
> Currently DOCTYPE is included in HtmlHead.ftl for cms.
> By doing so the DOCT YPE is always included on the top of the page before rendering single HTML statement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.